On 11.07.2011 12:35, Konstantin Kolinko wrote: > 2011/7/11 Rainer Jung <rainer.j...@kippdata.de>: >> On 11.07.2011 01:24, Konstantin Kolinko wrote:
>> I suggest we at least make the behaviour consistent: >> >> - Change the defaults to en_US > > I think it has to be en_US. Right. CLF will now always use en_US. Fortunately the Java 6 javadocs include the information, that Locale.US always has to exist. I also use Locale.US for formatting the timestamp that is part of the file name. That seems to be consistent with timestamps in other Tomcat log file names. >> - Allow to overwrite the locale used for formatting the lines in >> the access log > > Maybe, but I think that nobody asked. Committed in r1145166. By default all timestamps configured using an explicit SimpleDateFormat %{xxx}t will be formatted using the default locale. That is similar to e.g. timestamps contained in other log files. > There is another enhancement on todo list: > provide "encoding" option for AccessLogValve, > like already done for FileHandler in JULI. I guess that is https://issues.apache.org/bugzilla/show_bug.cgi?id=46252 The need for it isn't very convincing, at least after only looking at bugzilla. Regards, Rainer --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org