Author: kkolinko
Date: Sat Sep 24 23:31:04 2011
New Revision: 1175283
URL: http://svn.apache.org/viewvc?rev=1175283&view=rev
Log:
Cleanup temporary files created by tests:
register them and delete them in tearDown().
In TestRegistration also aligned mkdir calls with their usage elsewhere.
Modified:
tomcat/trunk/test/org/apache/catalina/connector/TestCoyoteAdapter.java
tomcat/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java
tomcat/trunk/test/org/apache/catalina/mbeans/TestRegistration.java
tomcat/trunk/test/org/apache/catalina/servlets/TestDefaultServlet.java
tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java
Modified: tomcat/trunk/test/org/apache/catalina/connector/TestCoyoteAdapter.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/connector/TestCoyoteAdapter.java?rev=1175283&r1=1175282&r2=1175283&view=diff
==============================================================================
--- tomcat/trunk/test/org/apache/catalina/connector/TestCoyoteAdapter.java
(original)
+++ tomcat/trunk/test/org/apache/catalina/connector/TestCoyoteAdapter.java Sat
Sep 24 23:31:04 2011
@@ -87,6 +87,7 @@ public class TestCoyoteAdapter extends T
// Create the folder that will trigger the redirect
File foo = new File(docBase, "foo");
+ addDeleteOnTearDown(foo);
if (!foo.mkdirs() && !foo.isDirectory()) {
fail("Unable to create foo directory in docBase");
}
Modified: tomcat/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java?rev=1175283&r1=1175282&r2=1175283&view=diff
==============================================================================
--- tomcat/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java
(original)
+++ tomcat/trunk/test/org/apache/catalina/core/TestAsyncContextImpl.java Sat
Sep 24 23:31:04 2011
@@ -411,6 +411,7 @@ public class TestAsyncContextImpl extend
// Create the folder that will trigger the redirect
File foo = new File(docBase, "async");
+ addDeleteOnTearDown(foo);
if (!foo.mkdirs() && !foo.isDirectory()) {
fail("Unable to create async directory in docBase");
}
Modified: tomcat/trunk/test/org/apache/catalina/mbeans/TestRegistration.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/mbeans/TestRegistration.java?rev=1175283&r1=1175282&r2=1175283&view=diff
==============================================================================
--- tomcat/trunk/test/org/apache/catalina/mbeans/TestRegistration.java
(original)
+++ tomcat/trunk/test/org/apache/catalina/mbeans/TestRegistration.java Sat Sep
24 23:31:04 2011
@@ -116,9 +116,9 @@ public class TestRegistration extends To
final Tomcat tomcat = getTomcatInstance();
final File contextDir = new File(getTemporaryDirectory(), "webappFoo");
- if (!contextDir.exists()) {
- if (!contextDir.mkdir())
- fail("Failed to create: [" + contextDir.toString() + "]");
+ addDeleteOnTearDown(contextDir);
+ if (!contextDir.mkdirs() && !contextDir.isDirectory()) {
+ fail("Failed to create: [" + contextDir.toString() + "]");
}
tomcat.addContext(contextName, contextDir.getAbsolutePath());
tomcat.start();
@@ -172,9 +172,9 @@ public class TestRegistration extends To
tomcat.getEngine().addChild(host);
final File contextDir2 = new File(getTemporaryDirectory(),
"webappFoo2");
- if (!contextDir2.exists()) {
- if (!contextDir2.mkdir())
- fail("Failed to create: [" + contextDir2.toString() + "]");
+ addDeleteOnTearDown(contextDir2);
+ if (!contextDir2.mkdirs() && !contextDir2.isDirectory()) {
+ fail("Failed to create: [" + contextDir2.toString() + "]");
}
tomcat.addContext(host, contextName + "2",
contextDir2.getAbsolutePath());
Modified: tomcat/trunk/test/org/apache/catalina/servlets/TestDefaultServlet.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/servlets/TestDefaultServlet.java?rev=1175283&r1=1175282&r2=1175283&view=diff
==============================================================================
--- tomcat/trunk/test/org/apache/catalina/servlets/TestDefaultServlet.java
(original)
+++ tomcat/trunk/test/org/apache/catalina/servlets/TestDefaultServlet.java Sat
Sep 24 23:31:04 2011
@@ -164,6 +164,7 @@ public class TestDefaultServlet extends
public void testCustomErrorPage() throws Exception {
File appDir = new File(getTemporaryDirectory(), "MyApp");
File webInf = new File(appDir, "WEB-INF");
+ addDeleteOnTearDown(appDir);
if (!webInf.mkdirs() && !webInf.isDirectory()) {
fail("Unable to create directory [" + webInf + "]");
}
@@ -249,6 +250,7 @@ public class TestDefaultServlet extends
public void testCustomErrorPageMissing() throws Exception {
File appDir = new File(getTemporaryDirectory(), "MyApp");
File webInf = new File(appDir, "WEB-INF");
+ addDeleteOnTearDown(appDir);
if (!webInf.mkdirs() && !webInf.isDirectory()) {
fail("Unable to create directory [" + webInf + "]");
}
Modified: tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java?rev=1175283&r1=1175282&r2=1175283&view=diff
==============================================================================
--- tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java (original)
+++ tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java Sat Sep
24 23:31:04 2011
@@ -24,6 +24,7 @@ import java.io.OutputStream;
import java.io.PrintWriter;
import java.net.HttpURLConnection;
import java.net.URL;
+import java.util.ArrayList;
import java.util.List;
import java.util.Map;
@@ -61,6 +62,8 @@ public abstract class TomcatBaseTest {
public static final String TEMP_DIR = System.getProperty("java.io.tmpdir");
+ private List<File> deleteOnTearDown = new ArrayList<File>();
+
/**
* Make Tomcat instance accessible to sub-classes.
*/
@@ -85,8 +88,15 @@ public abstract class TomcatBaseTest {
/**
* Helper method that returns the path of the temporary directory used by
- * the test runs. The directory is configured during {@link #setUp()} and
is
- * deleted at {@link #tearDown()}.
+ * the test runs. The directory is configured during {@link #setUp()}.
+ *
+ * <p>
+ * It is used as <code>${catalina.base}</code> for the instance of Tomcat
+ * that is being started, but can be used to store other temporary files as
+ * well. Its <code>work</code> and <code>webapps</code> subdirectories are
+ * deleted at {@link #tearDown()}. If you have other files or directories
+ * that have to be deleted on cleanup, register them with
+ * {@link #addDeleteOnTearDown(File)}.
*/
public File getTemporaryDirectory() {
return tempDir;
@@ -109,6 +119,17 @@ public abstract class TomcatBaseTest {
return accessLogEnabled;
}
+ /**
+ * Schedule the given file or directory to be deleted during after-test
+ * cleanup.
+ *
+ * @param file
+ * File or directory
+ */
+ public void addDeleteOnTearDown(File file) {
+ deleteOnTearDown.add(file);
+ }
+
@Before
public void setUp() throws Exception {
// Need to use JULI so log messages from the tests are visible
@@ -190,10 +211,14 @@ public abstract class TomcatBaseTest {
tomcat.destroy();
}
// Cannot delete the whole tempDir, because logs are there,
- // and they might be open for writing.
+ // and they might be open for writing.
// Delete known subdirectories of it.
- ExpandWar.delete(new File(tempDir, "webapps"));
- ExpandWar.delete(new File(tempDir, "work"));
+ deleteOnTearDown.add(new File(tempDir, "webapps"));
+ deleteOnTearDown.add(new File(tempDir, "work"));
+ for (File file : deleteOnTearDown) {
+ ExpandWar.delete(file);
+ }
+ deleteOnTearDown.clear();
}
/**
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
