On 22/12/2011 13:48, Olivier Lamy wrote:
> In o.a.t.u.m.Registry with changing
>
> private ModelerSource getModelerSource( String type )
> throws Exception
> {
> if( type==null ) type="MbeansDescriptorsDigesterSource";
> //if( type.indexOf( "" ) < 0 ) {
> if (type.length()>0) {
> type="org.apache.tomcat.util.modeler.modules." + type;
> }
>
> Class<?> c = Class.forName(type);
> ModelerSource ds=(ModelerSource)c.newInstance();
> return ds;
> }
>
> package was never added so CNFE.
> I wonder what is the need for this test ?
I've look at the code in trunk and it doesn't look quite like the
snippet above.
I'm not sure I understand that question you are asking. Could you
rephrase it?
As an aside, that is (if it isn't clear) a package renamed version of
commons modeler. I believe it is quite old and hasn't been kept in sync
with the changes in modeler. There is also a fair bit of it that isn't
used and could be removed. Running the unused code detector over the
Tomcat 8 source tree is on the todo list. That should remove a lot of
(what I believe is) unnecessary modeler code.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
