https://issues.apache.org/bugzilla/show_bug.cgi?id=52726
Bug #: 52726 Summary: An incomplete fix for the resource leak bug in MemoryUserDatabase.java Product: Tomcat 7 Version: trunk Platform: PC Status: NEW Severity: critical Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: liangg...@sei.pku.edu.cn Classification: Unclassified The fix revision 423920 was aimed to remove an resource leak bug on the FileInputStream object "fis" (created line 418) in the method "open()" of the file "/tomcat/trunk/java/org/apache/catalina/users/MemoryUserDatabase.java" , but it is incomplete. There are some problems: 1. when the statements at lines 420-439 throw some exception, the "fis" can not be closed as expected. The best way to close such resource objects is putting such close operations in the finaly block of a try-catch-finally structure. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org