https://issues.apache.org/bugzilla/show_bug.cgi?id=52800

             Bug #: 52800
           Summary: Please do not catch Throwable!
           Product: Tomcat 7
           Version: 7.0.26
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Catalina
        AssignedTo: [email protected]
        ReportedBy: [email protected]
    Classification: Unclassified


See also bug 48644.

I see "catch (Throwable ..." occurring 311 times in the Tomcat source:

mikevdg@xxx:~/src/apache-tomcat-7.0.26-src
$ grep -r "catch.*(.*Throwable" * | wc -l
311

Please at the very least, change these to "catch (Exception ...". Otherwise you
end up catching OutOfMemoryErrors.

IMHO, and I haven't grepped the mailing list for any controversy surrounding
this, when Tomcat (or anything!!!) receives an OOME, it should exit to the OS
to be restarted by whatever script or mechanism is managing it. You cannot
recover from an OOME, and I have to resort to SIGKILL to stop the JVM.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to