2012/3/20 <fha...@apache.org>:
> Author: fhanik
> Date: Tue Mar 20 15:45:19 2012
> New Revision: 1302948
>
> URL: http://svn.apache.org/viewvc?rev=1302948&view=rev
> Log:
> https://issues.apache.org/bugzilla/show_bug.cgi?id=52002 add in ability to
> configure pool so that connections can not be reused
>
> Added:
>
> tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DisposableConnectionFacade.java
>
> tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/MultipleCloseTest.java
> Modified:
>
> tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java
>
> tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java
>
> tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/JdbcInterceptor.java
>
> tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolConfiguration.java
>
> tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java
>
> tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/jmx/ConnectionPool.java
>
(...)
> ---
> tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java
> (original)
> +++
> tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java
> Tue Mar 20 15:45:19 2012
> @@ -86,6 +86,7 @@ public class PoolProperties implements P
> protected boolean alternateUsernameAllowed = false;
> protected boolean commitOnReturn = false;
> protected boolean rollbackOnReturn = false;
> + protected boolean useDisposableConnectionFacade;
>
>
> /**
> @@ -1194,4 +1195,29 @@ public class PoolProperties implements P
> public boolean getRollbackOnReturn() {
> return this.rollbackOnReturn;
> }
> +
> + /**
> + * {@inheritDoc}
> + */
> + @Override
> + public void setUseDisposableConnectionFacade(boolean
> useDisposableConnectionFacade) {
> + this.useDisposableConnectionFacade = useDisposableConnectionFacade;
> + }
> +
> + /**
> + * {@inheritDoc}
> + */
> + @Override
> + public boolean getUseDisposableConnectionFacade() {
> + return useDisposableConnectionFacade;
> + }
> +
> + @Override
> + protected Object clone() throws CloneNotSupportedException {
> + // TODO Auto-generated method stub
> + return super.clone();
> + }
There is no need in the above clone() method.
It has the same access level (protected) as super one.
I see that PoolProperties is written as "implements Cloneable". In
such case the clone method is usually redeclared as public one.
> +
> +
> +
> }
>
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
