-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 27/04/2012 01:37, Christopher Schultz wrote: > All, > > I've been doing some memory profiling on my webapp to see where I > can reduce our memory footprint a bit by combining equivalent > objects. YourKit has some nice utilities to look for duplicate > objects -- especially Strings. > > I can see that the string "java.lang.String" has lots of > duplicates. Many of the ones I've inspected so far can be > traced-back to catalina.mbeans.MBeanUtils and the registry of > MBeans that it contains. > > Would anyone object to using String-interning to share copies of > class names for MBeans? I could even restrict such interning to > Strings that start with "java.lang" since those are probably the > most-used ones, and those strings are probably already interned by > all the RTTI infrastructure in the JVM anyway.
In principle, no objection. As always, I'll reserve final judgement until I see the commit diff. Mark -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQIcBAEBAgAGBQJPmk2uAAoJEBDAHFovYFnnyT0P/RcD/tjhue64kOi/tNxA6nFT Sa+GCRpkQeaM1V8OovdzjQ09HjiHnwSdM2v0zLe5RsiohN0fJUr8ynVnCZUg8n1O aca5q++6gPQmYMjW1A+q9y0D08srcTygrT2vuvI2XFDrioiuKwrjrJxKJ3JW81U5 dkXIARArf0HXi/rHF92o7HxpZ0YbqKiRc+d34ATs+SBzKayio+EwEGPmWOYZoBbV lFQnoOlYeVQMlAFiPSn8qKFAE+jL5y9jUUQ49UmB9S/J43/bA+eAey881o/EePGR FMOOIJVfNZdFduLh/stPNLfxPo204dWzPawbLNbt1GNlkEO+GNeIwNYat+D3o1UK K7uN8ptxgp72L790+5VIkaQc1Nr5APtbvnooMG6zrVTT3KqeH0AFDnWjYTwTDQrC 8ZFW1nYV+bnppbuyest18UPKbclDiv7dVlFPIz8iqo+8qXj2YorMJOPtEECgGl/P cYqK+t3L7ukqYrtCqSLXdKEL6ydaJhWKHrJNsjC52PDVMTFtMbRdPeV2RDQ2jFwZ 7voZUL/CXB6xqvqEDSHLZuEZa4eUeKEGZf8eR8v+7V5XM1ix9r0r5jkWwWxlljjL qkJm0Rcj8BJjBP9475SL4iuvvVzS3XMx/gd2ZPKCt04YaAsqfK7tfis7aZOup9qm q/61iuBhdmusMOqn3Gwu =RMrw -----END PGP SIGNATURE----- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org