On 14/10/2012 00:05, Konstantin Kolinko wrote: > 2012/10/14 Mark Thomas <ma...@apache.org>: >> On 13/10/2012 22:43, ma...@apache.org wrote: >>> Author: markt >>> Date: Sat Oct 13 21:43:36 2012 >>> New Revision: 1397953 >>> >>> URL: http://svn.apache.org/viewvc?rev=1397953&view=rev >>> Log: >>> Run the UCDetector and remove unused code >>> Some follow-up remains. >> >> Drat. This clean-up was too aggressive. I need to revert all my changes >> from this one forward. Sorry for the noise. >> > > I think/suspect that you need to revert your toString() removal as well > URL: http://svn.apache.org/viewvc?rev=1397950&view=rev
I don't think so. > You have already reverted it once before > http://svn.apache.org/viewvc?view=revision&revision=1384063 That was because I incorrectly removed the stringifyValue() methods. > From buildbot logs: > http://ci.apache.org/builders/tomcat-trunk/builds/3465/steps/compile_1/logs/stdio > [[[ > [junit] Caused by: java.lang.StackOverflowError That is an issue with the error handling once the toString() methods have been removed, not directly an issue with removing the toString methods. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
