2012/11/6 <ma...@apache.org>: > Author: markt > Date: Tue Nov 6 14:52:00 2012 > New Revision: 1406156 > > URL: http://svn.apache.org/viewvc?rev=1406156&view=rev > Log: > Fix where possible and silence where not possible some deprecation warnings > > Modified: > tomcat/trunk/java/org/apache/jasper/runtime/PageContextImpl.java > > Modified: tomcat/trunk/java/org/apache/jasper/runtime/PageContextImpl.java > URL: > http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/runtime/PageContextImpl.java?rev=1406156&r1=1406155&r2=1406156&view=diff > ============================================================================== > --- tomcat/trunk/java/org/apache/jasper/runtime/PageContextImpl.java > (original) > +++ tomcat/trunk/java/org/apache/jasper/runtime/PageContextImpl.java Tue Nov > 6 14:52:00 2012 > @@ -28,6 +28,7 @@ import java.util.Enumeration; > import java.util.HashMap; > > import javax.el.ELContext; > +import javax.el.ELException; > import javax.el.ExpressionFactory; > import javax.el.ValueExpression; > import javax.servlet.RequestDispatcher; > @@ -44,7 +45,6 @@ import javax.servlet.jsp.JspException; > import javax.servlet.jsp.JspFactory; > import javax.servlet.jsp.JspWriter; > import javax.servlet.jsp.PageContext; > -import javax.servlet.jsp.el.ELException; > import javax.servlet.jsp.tagext.BodyContent; >
Just noting that this change of imports results in change in the type of ELException that is thrown by the "proprietaryEvaluate()" method in this class, because it will use a different exception now. Just highlighting it in case if it needs more review and as this change is not clear from the commit message. From the first look at it, the change looks OK. BTW, there are "XXX" comments on this PageContextImpl#proprietaryEvaluate() method and in o.a.jasper.compiler.JspUtil#interpreterCall(..) where it generates JSP java code that calls this method. The comments say that the intention was to remove this "proprietaryEvaluate()" method. Best regards, Konstantin Kolinko --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
