On 29/11/12 14:37, bugzi...@apache.org wrote:
https://issues.apache.org/bugzilla/show_bug.cgi?id=54190
Mark Thomas <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
--- Comment #6 from Mark Thomas <ma...@apache.org> ---
Thanks. Patch applied to trunk and 7.0.x and will be included in 7.0.34
onwards.
Applying the patch generated a bunch of IDE warnings (we try to keep the code
clean of those) which were fixed by r1415178 and r1415179.
Thanks Mark.
I use netbeans, not eclipse. My change was clear of ide warnings and it
also passed checkstyle.
When I looked quickly at your change, the "-" and "+" lines appeared to
be identical to me, so I was puzzled.
Could you give me an example of what kind of warnings you were getting -
I noticed that you commented on having more than 40, so just the most
common one or two would be a help.
Curiously, you haven't mentioned this kind of problem with my previous
patches, and all have been generated as svn diffs rather than ide diffs.
However, I have recently upgraded both netbeans and svn on my main system.
I probably need to adjust one of my netbeans settings to conform.
If you start looking at the TODOs, I suggest you take a look at
org.apache.tomcat.util.http.parser.HttpParser#parseAuthorizationDigest()
I suspect a new parseAuthorizationBasic() method is the way to go as that
should handle the various whitespace issues noted.
Noted. Assume that I will look into it unless you hear otherwise. I
won't open a bug against BasicAuthenticator yet.
Regards,
Brian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
