2013/1/8 Mark Thomas <[email protected]>: > On 08/01/2013 09:30, Konstantin Kolinko wrote: >> 2013/1/8 <[email protected]>: >>> Author: markt >>> Date: Mon Jan 7 20:18:09 2013 >>> New Revision: 1429991 >>> >>> URL: http://svn.apache.org/viewvc?rev=1429991&view=rev >>> Log: >>> Follow-up for r1429858. >>> Further fixes for https://issues.apache.org/bugzilla/show_bug.cgi?id=54371 >>> Handle the additional cases that r1429858 did not ('~', '+', ';' and '&' >>> characters in the context path) and simplify at the same time. > > <snip/> > >> 1. I have not tested it yet, but I doubt that this works for Tomcat 7. >> >> See BaseDirContext.list(String) how it processes the aliases and >> altDirContexts there. I think that calling collection.list() skips >> that processing. > > It is no worse than the current code. > > Consider the following: > > You use an empty directory as the basis of a web application. > You add an alias for WEB-INF/lib which points to a directory full of JARs. > > list("/") is going to return an empty set when you might expect it to > return a single entry for WEB-INF. > > I'm not particularly keen on trying to fix this particular issue as the > code is already rather fragile and there is a simple workaround: make > sure that the root of your alias (WEB-INF/lib in this case) exists in > the base directory. > > I will look at this for the new Tomcat 8 resources implementation to see > how it handles it and if any improvements are required. >
OK. Best regards, Konstantin Kolinko --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
