On 01/24/2013 01:50 AM, Konstantin Kolinko wrote:
2013/1/23 jean-frederic clere <jfcl...@gmail.com>:
Version 1.1.25 is bug fixing release.
The proposed release artefacts can be found at [1],
and the build was done using tag [2].

The VOTE will remain open for at least 48 hours.

The Apache Tomcat Native 1.1.25 is
  [ ] Stable, go ahead and release
  [x] Broken because of ...


1. "dev" flags were not removed before tagging.
For reference, how such change would look:
http://svn.apache.org/viewvc?diff_format=l&view=revision&revision=1348811

As of now, in /tags/TOMCAT_NATIVE_1_1_25/native/include/tcn_version.h there is
#define TCN_IS_DEV_VERSION      1

Oops that is bad.


2. Windows binaries do include 32-bit and x64 versions, but there is
no i64 version of the DLL.

I do not know whether there is real demand for supporting Itanium
CPUs, but as of now a release build of Tomcat needs i64 version of the
DLL. If there is no i64 version, someone would have to change the
windows installer script, build.xml and readme files in Tomcat 6 & 7.

I am not sure I am able to build i64 binaries.


2.2. Minor notes:
- What are those "oscp-win32" binaries?
- There are no *.md5 files for Windows binaries.
- It is a bit odd that the file is named "win32", while 64-bit
versions are also in it.

They have OSCP support and they were in the 1.1.24.


3. If this release were rerolled, it would be nice to include
http://svn.apache.org/viewvc?rev=1437082&view=rev

Sure

Cheers

Jean-Frederic

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to