On Mon, Jan 28, 2013 at 3:46 AM, Mark Thomas <ma...@apache.org> wrote:
> On 26/01/2013 21:51, Henri Yandell wrote:
>> On Fri, Jan 18, 2013 at 8:30 AM, Jeremy Boynes <jer...@boynes.com> wrote:
>>> On Jan 18, 2013, at 1:34 AM, Konstantin Kolinko wrote:
>>>> Regarding the two taglibs that are not yet in the attic, I have no
>>>> interest in "RDC" taglib, but I am interested in JSTL one.
>>>
>>> +1
>>>
>>>>
>>>> I think once we make the first release, things should go easier after that.
>>>>
>>>> A few notes after quick review of the sources:
>>>>
>>>> 1. Can we go up from Java 5 and require/use at least Java 6 to build
>>>> the project?
>>>>
>>>> I am even OK to be brave and go up to Java 7.
>>>>
>>>> I do not like Java 5, because
>>>> a) It is outdated.
>>>> It would be strange for a "new" project to use that if we are going
>>>> to support it for long.
>>>> b) It is not opensource.
>>>> OpenJDK is since Java 6.
>>>>
>>>> The version of Java is important for this class, that implements
>>>> javax.sql.DataSource:
>>>>
>>>> \standard\impl\src\main\java\org\apache\taglibs\standard\tag\common\sql\DataSourceWrapper.java
>>>>
>>>> Java 7 will allow us to support a later version of JDBC and will allow
>>>> this project to build on Gump.
>>>
>>> There is also an issue with the I18N tags taking a long time to start on a
>>> Java6 platform due to changes in the way Locales are located by the JRE. I
>>> remember some discussion on fixing this but a requirement to stay on Java 5
>>> meant having to build two implementations and switch between them which I'd
>>> planned to do once a release was out. If we pre-req 6 or 7 then the
>>> implementation can just be updated and this issue closed easier.
>>
>> Would the TCK pass if it was on Java 7?
>
> We are talking about Taglibs 1.2 right? (If not adjust versions below
> accordingly).
>
> Taglibs 1.2 requires JSP 2.1.
>
> JSP 2.1 requires Java 5 or later (as does Servlet 2.5 and J2EE 5).
>
> Based on that, I would say that the TCK has to pass when running on Java 5.
>
> /me goes looking for some TCK docs
>
> I've just checked the latest version of the TCK documentation for JSTL
> 1.2 and while the TCK has been updated so it will run on Java 7, the
> reference runtime remains Java 5. My interpretation of that is that the
> TCK must pass when running with a Java 5 JRE.
We could use the Tomcat trick though. if("passTCKFlag") then do the
no-one-wants option. Then by default it could run smoothly on JDK 7.
I've vague memories that the SQL side of things makes that painful.
Did you look at that Jeremy?
Hen
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
