(I'm replying to both your emails here. Forgive me.) -----Original Message----- From: Mark Thomas [mailto:ma...@apache.org] Sent: Monday, February 11, 2013 2:38 PM To: Tomcat Developers List Subject: Re: EL 3.0, HttpSessionIdListener, HttpServletRequest#changeSessionId()
>> Fascinating. Years ago I used to think the "spec" included a bunch of >> already-compiled interfaces and you just copied the spec jar to your >> implementation and then implemented the spec. I got the idea a while >> ago that it wasn't quite that simple, but I had no idea y'all >> literally just wrote the javax.* interfaces and classes from scratch >> based on the spec. > >We have to so we have an ALv2 licensed version of the API. Makes sense. >> Is the spec repository public? I looked around a bit and I found some >> jars (or is that what you meant, since you're using javap?), but no >> repository. > >http://java.net/projects/servlet-spec/ > >You'll almost certainly need to register to access it but it should be >readable once you do. Low and behold, I was already registered and didn't know it. Unfortunately, "You are not allowed to do that (read scm)." >I argued for (and got) a name change from ProtocolHandler to >HttpUpgradeHandler that hasn't been implemented yet. Name changes are usually >easier for committers to handle though the IDE since the effort is minimal but >the diff can be big and reviewing a large diff is a pain. > >I've just implemented this. I noticed. Five minutes after I did all of my analysis there was this HUGE check-in by someone named Mark T that invalidated it all. :-P >I haven't done anything about the method signature change. Yea, I figure that requires some more work yet. By the way, the HttpUpgradeHandler you checked in is missing the public abstract void destroy() method, but I'm sure you probably already knew that. >> javax.servlet.http.HttpServletRequestWrapper: changeSessionId() >> missing >Yep. Missing feature. I'll work on this one. >> javax.servlet.http.HttpSessionIdListener: missing in Tomcat And this one as well, since it goes with changeSessionId() >> javax.servlet.http.HttpUpgradeHandler: missing in Tomcat >Missing features. Not anymore, you just added it. :-) <snip /> The diff since your lash check-ins shows it to be much closer to the spec now. This e-mail may contain privileged or confidential information. If you are not the intended recipient: (1) you may not disclose, use, distribute, copy or rely upon this message or attachment(s); and (2) please notify the sender by reply e-mail, and then delete this message and its attachment(s). Underwriters Laboratories Inc. and its affiliates disclaim all liability for any errors, omissions, corruption or virus in this message or any attachments. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
