Author: kkolinko
Date: Mon Mar 25 11:40:40 2013
New Revision: 1460626
URL: http://svn.apache.org/r1460626
Log:
Followup to r1454962
Simplify code, move prefix string outside the loop
I have not profiled this, but looking at source code
Class.getPackage() relies on Class.getName() and ClassLoader.getPackage(name),
and thus have to be slower than just calling getName().
Modified:
tomcat/trunk/java/org/apache/tomcat/websocket/server/WsSci.java
Modified: tomcat/trunk/java/org/apache/tomcat/websocket/server/WsSci.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/websocket/server/WsSci.java?rev=1460626&r1=1460625&r2=1460626&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/tomcat/websocket/server/WsSci.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/websocket/server/WsSci.java Mon Mar 25
11:40:40 2013
@@ -56,10 +56,12 @@ public class WsSci implements ServletCon
Set<Class<?>> scannedPojoEndpoints = new HashSet<>();
try {
+ // wsPackage is "javax.websocket."
+ String wsPackage = ContainerProvider.class.getName();
+ wsPackage = wsPackage.substring(0, wsPackage.lastIndexOf('.') + 1);
for (Class<?> clazz : clazzes) {
// Protect against scanning the WebSocket API JARs
- if (clazz.getPackage().getName().startsWith(
- ContainerProvider.class.getPackage().getName())) {
+ if (clazz.getName().startsWith(wsPackage)) {
continue;
}
if (ServerApplicationConfig.class.isAssignableFrom(clazz)) {
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
