https://issues.apache.org/bugzilla/show_bug.cgi?id=51294
--- Comment #22 from Mark Thomas <ma...@apache.org> --- (In reply to comment #20) > Why didn't you just clean up the docs and make the docs match the code > instead of changing the code to match the docs? Again, because this undocumented behavior created a lot of edge cases that weren't handled by the automatic deployment code. > Seems like a lot less work to type in a paragraph in the docs than change > code! The options, with the one requiring the least effort first were: 1. add a check to the code to prevent the undocumented behaviour 2. modify the docs to reflect the current behaviour highlighting the various edge cases that it could cause and explaining how to avoid them 3. implement the requested feature properly with the edge cases all thought through and update the docs to add the new feature 1 was implemented at the time. This enhancement request is for 3. > Look at how much more > typing everyone on the internet has now done in response to this change! And it is a pity so little of it has been constructive. If the same efforts had been directed towards constructive ends this issue would be closer to being resolved. > The rest of the reasons for changing code that I read didn't make a > compelling reason to change it other than it might have simplified the code. You misunderstand the simplification argument. Prior to the change, external WARs were unpacked but this was neither the intended nor the documented behaviour. Unpacking external WARs creates additional edge cases that needed to be thought through and correctly handled. That would have required a reasonable amount of change to code that is already fairly complex. The simpler option was to prevent this unintended behaviour until such time as this feature could be properly implemented. > Well of course it did a feature was removed. It's not like it was > refactored. Code was just deleted. The above statement is incorrect. Clearly you made an assumption rather than looked at the source code to see how the change was implemented [1]. Making assumptions like that only serve to damage your credibility and undermine any valid arguments you may be making. [1] http://svn.apache.org/viewvc/tomcat/tc7.0.x/tags/TOMCAT_7_0_12/java/org/apache/catalina/startup/ContextConfig.java?r1=1079769&r2=1080719&diff_format=h -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
