https://issues.apache.org/bugzilla/show_bug.cgi?id=51813
--- Comment #9 from Christopher Schultz <ch...@christopherschultz.net> --- (In reply to Rainer Jung from comment #8) > (In reply to Christopher Schultz from comment #7) > > Created attachment 30402 [details] > > Patch against tcnative-1.1.x > > > > I'm not sure if I should be checking s->net or s->sock. They both seem to be > > set to NULL in the various recycle routines so it probably doesn't matter > > either way. > > I'd go with the net member and add the check to and function of name send* > and recv*, which already have the null pointer check for s (or its jlong > equivalent sock). I think that's pretty much what I've done. Do you think I missed anything? > > I'm also not sure if APR_EINVALSOCK is the right error code to use. > > * APR_EINVALSOCK APR was given an invalid socket > * APR_ENOSOCKET APR was not given a socket > > So APR_EINVALSOCK sounds good. Okay, I'll commit as-is, then. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
