2013/8/6 Mark Thomas <ma...@apache.org>:
> Rainer (or anyone else that can figure this out),
>
> I am in the process of fixing [1] and find myself having to revert some
> of one of your commits [2]. My concern is that I can't figure out what
> problem [2] was meant to solve and how it solves it.
>
> The problem is that the WsSessionListener does not have a zero-arg
> constructor. There is a statement in Servlet 3.1 section 11.3.1 that
> indicates that it should, be that looks to be out-dated and aimed at
> web.xml configuration (where a zero arg constructor is obviously required).
>
> Mark
>
> [1] https://issues.apache.org/bugzilla/show_bug.cgi?id=55365
> [2] http://svn.apache.org/viewvc?view=revision&revision=932969
>
Looking at [2],
+ classCache.put("addFilter", new Class[]{String.class, String.class});
in Servlet 3.0 there are 3 different methods with the same name
public FilterRegistration.Dynamic addFilter(String filterName,
String className) {
public FilterRegistration.Dynamic addFilter(String filterName,
Filter filter) {
public FilterRegistration.Dynamic addFilter(String filterName,
Class<? extends Filter> filterClass) {
Using classCache for their argument types is a bit confusing.
Thus one method of the three there should use doPriviledged(...,
Object[]) and benefit from caching and two others should use
doPriviledged(..., Class[], Object[]) and bypass the cache.
>From r1511217 I think you have already figured this.
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
