-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 23/11/2013 04:14, Jeremy Boynes wrote: > On Nov 22, 2013, at 8:24 AM, Mark Thomas <[email protected]> wrote: > >> Signed PGP part On 22/11/2013 16:18, Jeremy Boynes wrote: >>> On Nov 22, 2013, at 5:40 AM, Mark Thomas <[email protected]> >>> wrote: >>> >>>> On 22/11/2013 13:04, Konstantin Kolinko wrote: >>>>> 2013/11/22 Mark Thomas <[email protected]>: >>> ... >>>> >>>>> It does not mention anything else. >>>>> >>>>> There might be 3rd-party tag libraries that do not >>>>> validate. I think it is good to have a separate option. >>>> >>>> OK. That is enough to nudge me off the fence. I'll get that >>>> code re-instated. Another advantage is that 7.0.x and 8.0.x >>>> will the same code. >>> >>> Is the change backward compatible in 7.0.x? E.g. does >>> "validating" init-param for JspServlet still work? >> >> Where is (was?) that in the 7.0.x code base? I can;t see it now >> and I don't recall removing it from 7.0.x. > > This was the change: > http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/jasper/EmbeddedServletOptions.java?r1=1155369&r2=1544198&diff_format=h > > Looking at the code, it looks the option wouldn't work in the > first place as the default value in ParserUtils is false and ESO > never sets the value true.
I did a little digging and it has been like that for all of 6.0.x and all of 7.0.x. Given that there have been no bug reports, I'm confident that no-one has been trying to use that feature. I also couldn't find any documentation on it. Therefore, I'm happy removing the code. Mark -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSkxq4AAoJEBDAHFovYFnngJsP/1PeBZEl0R3jSdtRNheV/EaK jOc8IjBEbH80Wh1iAJjiW6Z6FVPvfvZiwlMEvMgHCGePTHX3LYx8NnHetWDlyv2J HUiq7PTeetjdK/sG6jpKZ+hdaWYBXNlh/nPrCgj+XQrIoxGFRUVUjtoZrECNNEfz H+oRPvH/j5cqGqk40l/0Bpo+f+vo9+pqoEh7PEtf+nc3XVNXOJkcmZ4zJ+t7BIjg zZQghd6HjFYd0R/rts0eSw1UaJAl57WpMkGDf5mO9oUDyMW44POgU1VKUMoDbalv t5Cgzd1u5sHMy281bhB3eiEXaMF5I/cpfcYbO53qt9wvx3kulvF3FdrpxKn698Am HZMmJFvP9AXM+amMf4eZwjhfWJsr9ukqOE8MB3K6Hy4L2+QPeKUrW2qseVb+teov w6t/joe7TNTqtUrgLWCZf9VWvNct9pdHOAzOWWgZkBZ2AtjL6yAWGZGeE1i8dBhL ARhZKot+F80l8JA+SH0TITMw15i1m3Uw02HZWy+wJykE/ju5F/Ypg8+G1451lmX8 E97mo1VMiT0vWwFJNQNEU65k9F5x2hwQ1MYAG2bii67zWsuVSz/pWRa3xmduSYJL 40nSbOuvmMfNevYEfjvAQ1wIVZa9B0FxiMcNHutiysOBExaDq5em6uoeXpw7yVEX eHZUQRWTcgnKfpn6Ytl7 =1Ae9 -----END PGP SIGNATURE----- --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
