Author: remm
Date: Mon Jan 13 12:38:30 2014
New Revision: 1557691
URL: http://svn.apache.org/r1557691
Log:
Votes.
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1557691&r1=1557690&r2=1557691&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Jan 13 12:38:30 2014
@@ -35,7 +35,7 @@ PATCHES PROPOSED TO BACKPORT:
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55759
Update the Eclipse compiler to 4.3.1
http://svn.apache.org/viewvc?view=revision&revision=1539953
- +1: markt
+ +1: markt, remm
+0: kkolinko: A Tomcat6-specific patch is needed. It needs update to jar
exclude lists in TldConfig.java, TldLocationsCache.java, see r1476932.
-1:
@@ -64,7 +64,7 @@ PATCHES PROPOSED TO BACKPORT:
* Back-port from XML processing improvements (part 5)
Switch to a per context configuration for the XML digester
http://people.apache.org/~markt/patches/2014-01-08-xml-prep-part5-tc6-v1.patch
- +1: markt, kkolinko
+ +1: markt, kkolinko, remm
-1:
kkolinko: I see no need for the new non-static "createWebXmlDigester(..)"
method to be public. It returns 'void', so it is unlikely for it to be
@@ -81,7 +81,7 @@ PATCHES PROPOSED TO BACKPORT:
code with the current Tomcat 7 code to validate the correctness of the
back-port
http://people.apache.org/~markt/patches/2014-01-08-xml-prep-part6-tc6-v1.patch
- +1: markt, kkolinko
+ +1: markt, kkolinko, remm
-1:
kkolinko: It would be easier to review without all those trailing
whitespace changes.
@@ -90,7 +90,7 @@ PATCHES PROPOSED TO BACKPORT:
Switch o.a.catalina classes to use the new ErrorHandler
Back-port of http://svn.apache.org/r1547937
http://people.apache.org/~markt/patches/2014-01-08-xml-prep-part7-tc6-v1.patch
- +1: markt, kkolinko
+ +1: markt, kkolinko, remm
-1:
* Back-port from XML processing improvements (part 8)
@@ -99,7 +99,7 @@ PATCHES PROPOSED TO BACKPORT:
http://people.apache.org/~markt/patches/2014-01-08-xml-prep-part8-tc6-v1.patch
plus
http://svn.apache.org/1556840 to address kkolinko's comment
- +1: markt
+ +1: markt, remm
+1: kkolinko (would be better with a fix to BZ 55974, so that the first
error is reported like the old code does, not a random one)
-1:
@@ -108,7 +108,7 @@ PATCHES PROPOSED TO BACKPORT:
Switch JspDocumentParser to an DefaultHandler2
Back-port of http://svn.apache.org/r1547948
http://people.apache.org/~markt/patches/2014-01-08-xml-prep-part9-tc6-v1.patch
- +1: markt, kkolinko
+ +1: markt, kkolinko, remm
-1:
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55973
@@ -120,14 +120,14 @@ PATCHES PROPOSED TO BACKPORT:
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55119
Avoid CVE-2013-1571 when generating Javadoc
http://svn.apache.org/r1495875
- +1: markt
+ +1: markt, remm
+1: kkolinko (The fix goes into dist.xml)
-1:
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55671
Consistent naming for genStringAsCharArray
https://issues.apache.org/bugzilla/attachment.cgi?id=31187
- +1: markt
+ +1: markt, remm
-0: kkolinko: I think "genStrAsCharArray" is the proper and
documented name for Tomcat 6. If we change the init-param name
for better compatibility with Tomcat 7 (a good thing, +1),
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]