2014-03-05 11:07 GMT+01:00 Konstantin Kolinko <knst.koli...@gmail.com>:

> In my opinion, this is wrong. One should not skip access logging.
> If context==null, it can be logged via CoyoteAdapter.log(...) that
> logs into (ROOT app or Host or Engine).
>

Ok, I'll try to improve it. I see the call at the end of event is unsafe as
well, since it would skip recycling if something bad happens.

>
> There are several other places in CoyoteAdapter where
> context.logAccess(..) is called. Some are with similar NPE checks,
> some are not.
>
> Rémy

Reply via email to