https://issues.apache.org/bugzilla/show_bug.cgi?id=56343

--- Comment #8 from Mark Thomas <ma...@apache.org> ---
The public API for the Tomcat implementation of the Java WebSocket 1.0 API and
any other implementation (inlcuding the RI) should be identical. I was checking
this regularly all the way through development so there should not be any
differences. If you have spotted a difference in the public API then please
open a separate Bugzilla issue for that. Note that the actual implementation
beind the API may well differ.

What appears to have happened here is that the Tomcat implementation and the RI
are both correctly treating a null client configurator as meaning "use the
default NO-OP implementation" but Tomcat and the RI have implemented that
differently. The differences stem from Tomcat's desire to have a single default
Configurator instance to reduce memory footprint and GC. The difference is
problematic because the difference crosses the boundary between the API classes
and the implementation classes.

I'm leaning towards calling this a bug in Tomcat primarily because of the
Javadoc for ClientEndpointConfig.Builder.configurator(). Tomcat calls this with
null which arguably is the wrong thing to do. It would certainly be safer (and
should have the same end result) not to call the method at all in this case.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to