2014-04-04 23:10 GMT+04:00 Mark Thomas <ma...@apache.org>:
> On 04/04/2014 17:46, kkoli...@apache.org wrote:
>> Author: kkolinko
>> Date: Fri Apr 4 16:46:37 2014
>> New Revision: 1584806
>>
>> URL: http://svn.apache.org/r1584806
>> Log:
>> Revert r1584800.
>> It was:
>> Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=56283
>> Add Java 8 support to Jasper's default configuration
>>
>> It does not compile with JDK 1.5.0_20:
>> There is a problem with org.eclipse.jdt.core.compiler.IProblem class
>> (imported by Jasper's JDTCompiler)
>> [javac] class file has wrong version 50.0, should be 49.0
>
> Hmm. That is annoying. We can't build or ship Tomcat 6 with this version
> of JDT. However, I wonder if we can make all the other changes apart
> from changing the JDT JAR so that users that want to use Tomcat 6 with
> Java 8 can do so by replacing the JDT JAR.
>
I attached the patch ("v2") to Bugzilla.
It does compile etc., but I have not tested it with Java 8 yet.
> On the other hand, if someone is going to update the JVM to Java 8 then
> they may as well update Tomcat to 7.0.x or later at the same time. On
> that basis I wonder if there is much point in trying to support Java 8
> in Tomcat 6 at all.
It makes sense to support dropping-in of later versions of ECJ, in
case the current version has some bugs.
I see little practical sense in supporting
compilerSourceVM/compilerTargetVM = 1.8 in Tomcat 6, but technically I
have no objections if somebody wants this feature.
For the record:
ECJ 4.3.2 is OK to be used as replacement for 4.3.1 - it has the same
mix of 1.2/1.6 classes.
ECJ 4.4M6 uses 1.6 for all classes.
https://people.apache.org/~kkolinko/patches/jarcheck/
Best regards,
Konstantin Kolinko
>
> Thoughts?
>
> Mark
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
