-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 22/04/2014 21:15, Christopher Schultz wrote: > Mark, > > On 4/22/14, 3:58 PM, Mark Thomas wrote: >> On 22/04/2014 20:53, Christopher Schultz wrote: >>> Mark/Konstantin, >> >>> On 4/18/14, 11:29 AM, kkoli...@apache.org wrote: >>>> Author: kkolinko Revision: 1588102 Modified property: >>>> svn:log >>>> >>>> Modified: svn:log at Fri Apr 18 15:29:06 2014 >>>> ------------------------------------------------------------------------------ >>>> >>>> >> >>>> - --- svn:log (original) >>>> +++ svn:log Fri Apr 18 15:29:06 2014 @@ -1 +1,3 @@ Fix an >>>> Eclipse nag +Correct signature of SSL.fipsModeGet(), +as >>>> native code is implemented as throwing an Exception in this >>>> method. >> >>> Why single-out this method only to have its method signature >>> changed? >> >>> Nearly every native method in SSL.java can throw an exception. >>> I was just following convention. >> >> Because you documented the Exception in the Javadoc without >> declaring it in the code and that triggered an IDE warning. The >> 8.0.x code is kept warning free so either the Javadoc had to be >> removed or the declaration corrected. Correcting the declaration >> seemed to be the better option since it is possible for an >> exception to be thrown in this case. > > Fair enough. Shall we change the other methods in SSL.java as > well?
That is worth doing but I'd do that as a separate clean up task. > Any particular reason you removed the 'final' from fipsModeState? Yes. If the reason is not immediately obvious to you I suggest you restore it and then try and compile the class. Mark -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJTVs6mAAoJEBDAHFovYFnnivYQAKQDeQa4bFO0ewqFhQz9UQt1 zPYIBzK/grOID+SPdPLWbmL4bq2G4K1PuZFvvjwfGYzdYVFoLZ0a5sauGc3WWv2/ seGQ00kqOLCr4SiXslvyYTq35hewoJTcrCONzQ880IHqQ5VgrB0G2ZAKewpJBX+S 6bvr90CZLgBTP/Myl16RkBr6fW5y2yOIh6RMnYwbCby+Nw7fqxzsNTdCFyvtfpIQ G/41Xa3c2msNL+0uReKrOBM9fgN9Y/HPIWc5NTlqHC/RB9RcmX9C6pP/GSomIwBs XEJ8WUoLfvc2ynH0HjWw33Cu2/+IwlG8xoubJE2ragOBSKGOCHUle2SNF7/1/itc vZsR/G3GB46BuMFMShQ726mEX3g4UFnriAg+9Jz+s5CMx64QPgro1cVWVsgXTb6v DUNDQkzAAaATxeurvaog6B8Yo3HIGONk5IooA/PwyN4rDTDhaoWYGNfleZvVfbxt 98Mt1T5Dbkr/bqhxb5Rwht3al7gUMZ2RGxf1rhid5AFv8pdcPcpqLU7jVzfNFo46 1CMpO8HYpMe1Wa1nfeN5Yjl3h5YiqMCDhnse23JYr1N9m0JvLy73EQJE1vuPnr7T K1ngelviByJom3SAuxjPS7EfVVDn1k2HLwn7gKz1iO971tANyrm12i/MHRq66v/1 DqmvW9ZsUQSxtfLNgsAy =nMMw -----END PGP SIGNATURE----- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
