https://issues.apache.org/bugzilla/show_bug.cgi?id=56418
Sylvain Laurent <slaur...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #31536|0 |1
is obsolete| |
--- Comment #2 from Sylvain Laurent <slaur...@apache.org> ---
Created attachment 31554
--> https://issues.apache.org/bugzilla/attachment.cgi?id=31554&action=edit
Proposed patch on tomcat7 trunk
(In reply to Christopher Schultz from comment #1)
> The first and second chunks of your patch change behavior (by adding an
> isAvailable check). Is that the real fix for this bug?
Yes, exactly.
>
> In general, I'm not a fan of having a "check" method dump anything to the
> output writer. Would it be possible to re-write the patch with the
> re-factored method but not dump any output? Or, maybe just change the name
> so it's clear that stuff will be printed to the output writer (even though
> it should be obvious to the reader than the writer is bring used since it's
> passed as a parameter).
OK, I renamed the method to "checkAndOutputContextDeploymentStatus", see new
patch attached.
If this is OK, I can commit it since I should still have commit rights.
But I did not follow much tomcat dev lately : should I commit on 8.x then 7.x
? should I update the changelog in the same commit or different one ?
Or if you prefer to commit this yourself, be my guest ;-)
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
