https://issues.apache.org/bugzilla/show_bug.cgi?id=56667
Bug ID: 56667
Summary: "commit_all_members" logs wrong "to" activation state
Product: Tomcat Connectors
Version: 1.2.40
Hardware: PC
OS: Linux
Status: NEW
Severity: normal
Priority: P2
Component: mod_jk
Assignee: [email protected]
Reporter: [email protected]
When changing the activation state using "Edit all members", instead of logging
the new state, the old state is logged. This is massively confusing.
To solve this problem, the code changing the state needs to be moved before the
logging statement:
--- common/jk_status.c-orig 2014-06-24 16:54:51.000000000 +0200
+++ common/jk_status.c 2014-06-24 16:55:19.000000000 +0200
@@ -3601,10 +3601,10 @@
if (rv == JK_TRUE) {
i = jk_lb_get_activation_code(arg);
if (i != wr->activation && i >= 0 && i <=
JK_LB_ACTIVATION_MAX) {
+ wr->activation = i;
jk_log(l, JK_LOG_INFO,
"Status worker '%s' setting 'activation'
for sub worker '%s' of lb worker '%s' to '%s'",
w->name, wr->name, name,
jk_lb_get_activation(wr, l));
- wr->activation = i;
rc = 1;
sync_needed = JK_TRUE;
}
While working on this, I found that logging both old and new state would be
much more useful, like in:
[Tue Jun 24 16:49:55.412 2014] [28769:140012450096896] [info]
commit_all_members::jk_status.c (3607): Status worker 'jkmanager' setting
'activation' for sub worker 'censored' of lb worker 'secret' from 'ACT' to
'DIS'
A patch for this format change is appended.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
