Hi,
2014-07-09 21:10 GMT+03:00 Violeta Georgieva <miles...@gmail.com>:
>
>
> Hi,
>
> 2014-07-09 17:35 GMT+03:00 Konstantin Kolinko <knst.koli...@gmail.com>:
>
> >
> > 2014-07-09 6:39 GMT+04:00 Konstantin Kolinko <knst.koli...@gmail.com>:
> > > 2014-07-08 13:45 GMT+04:00 Konstantin Kolinko <knst.koli...@gmail.com
>:
> > >> 2014-07-08 13:17 GMT+04:00 Mark Thomas <ma...@apache.org>:
> > >>> On 27/06/2014 17:20, Konstantin Kolinko wrote:
> > >>>> 2014-06-27 18:16 GMT+04:00 Mark Thomas <ma...@apache.org>:
> > >>>>> On 23/06/2014 14:00, Violeta Georgieva wrote:
> > >>>>>> 2014-06-22 21:33 GMT+03:00 Konstantin Kolinko
> > >>>> Mapper issues:
> > >>>> BZ 44312: Fixed. Proposed for 6.0.
> > >>>>
> > >>>> BZ 56653: Fix re-implemented in Tomcat 8 to be less intrusive.
> > >>>> Not backported.
> > >>>> I backported testcase for it (r1604846), but neither Gump nor
Testbot
> > >>>> fail with it.
> > >>>>
> > >>>> BZ 56658: Not started.
> > >>>>
> > >>>> I plan to work on Mapper tonight and tomorrow.
> > >>>
> > >>> Any progress on this? Looking at Bugzilla, these are the only open
> > >>> issues for 7.0.x and I assume we want to resolve them before a
7.0.55 tag.
> > >>
> > >> All are fixed in Tomcat 8 a week ago.
> > >>
> > >> I shall backport 56653, 56658 to Tomcat 7 today.
> > >>
> > >
> > > Issue 56653 fixed. This leaves 56658.
> >
> > Issue 56658 fixed.
> >
> > Mapper issues fixed. I did run testsuite with NIO connector - all OK.
> >
> > I think we are OK to go with a release.
>
> Thanks a lot.
> I'll start the tagging tomorrow.
I'm receiving the following exception:
[exec] [junit] Jul 10, 2014 11:33:16 PM
org.apache.coyote.http11.AbstractHttp11Processor process
[exec] [junit] SEVERE: Error processing request
[exec] [junit] java.lang.ArrayIndexOutOfBoundsException: -1
[exec] [junit] at
org.apache.tomcat.util.http.mapper.Mapper.internalMap(Mapper.java:785)
[exec] [junit] at
org.apache.tomcat.util.http.mapper.Mapper.map(Mapper.java:662)
[exec] [junit] at
org.apache.catalina.connector.CoyoteAdapter.postParseRequest(CoyoteAdapter.java:714)
[exec] [junit] at
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:403)
[exec] [junit] at
org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1070)
[exec] [junit] at
org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:611)
[exec] [junit] at
org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:314)
[exec] [junit] at
java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
[exec] [junit] at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
[exec] [junit] at
org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
[exec] [junit] at java.lang.Thread.run(Thread.java:662)
The following "quick" patch fixes the problem:
Index: C:/tc7.0.x/java/org/apache/tomcat/util/http/mapper/Mapper.java
===================================================================
--- C:/tc7.0.x/java/org/apache/tomcat/util/http/mapper/Mapper.java (revision
1609565)
+++ C:/tc7.0.x/java/org/apache/tomcat/util/http/mapper/Mapper.java (working
copy)
@@ -779,18 +779,21 @@
if (version != null) {
contextVersion = exactFind(contextVersions, version);
}
+ if (contextVersion == null) {
+ // Return the latest version
+ contextVersion = contextVersions[versionCount - 1];
+ }
+ } else if (versionCount == 1) {
+ contextVersion = contextVersions[0];
}
- if (contextVersion == null) {
- // Return the latest version
- contextVersion = contextVersions[versionCount - 1];
+
+ if (contextVersion != null) {
+ mappingData.context = contextVersion.object;
+ mappingData.contextSlashCount = contextVersion.slashCount;
+ // Wrapper mapping
+ internalMapWrapper(contextVersion, uri, mappingData);
}
- mappingData.context = contextVersion.object;
- mappingData.contextSlashCount = contextVersion.slashCount;
-
- // Wrapper mapping
- internalMapWrapper(contextVersion, uri, mappingData);
-
}
>
> Regards,
> Violeta
>
> >
> > Best regards,
> > Konstantin Kolinko
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> > For additional commands, e-mail: dev-h...@tomcat.apache.org
> >
