https://issues.apache.org/bugzilla/show_bug.cgi?id=56842
Mark Thomas <ma...@apache.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED --- Comment #7 from Mark Thomas <ma...@apache.org> --- Remy has applied this path so closing the issue. I too preferred the JSSE names closer to the OpenSSL names which is why I didn't use varargs when I added the JSSE names in the first place. The var args is cleaner but it does make it a little harder to review since the names are further apart. I guess this makes me -0 on the move to varargs. The original patch could have done more on the cleaner code front by making the formatting of the cipher definitions more consistent rather than less consistent. I've just done a couple of global search and replaces to fix the inconsistencies introduced by this patch and some others I spotted. The original patch also introduced some trailing whitespace (now removed) and a redundant type argument (also removed). -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org