On 04/09/2014 10:50, Mark Thomas wrote:
> On 04/09/2014 10:16, Mark Thomas wrote:
>> On 04/09/2014 10:11, Mark Thomas wrote:
>>> On 04/09/2014 08:05, Martin Grigorov wrote:
>>>> On Wed, Sep 3, 2014 at 8:37 PM, <ma...@apache.org> wrote:
>>>>
>>>>> Author: markt
>>>>> Date: Wed Sep 3 17:37:51 2014
>>>>> New Revision: 1622302
>>>
>>> <snip/>
>>>>> ---
>>>>> tomcat/tc7.0.x/trunk/test/org/apache/catalina/connector/TestRequest.java
>>>>> (original)
>>>>> +++
>>>>> tomcat/tc7.0.x/trunk/test/org/apache/catalina/connector/TestRequest.java
>>>>> Wed Sep 3 17:37:51 2014
>>>>> @@ -28,6 +28,7 @@ import java.net.URL;
>>>>> import java.util.ArrayList;
>>>>> import java.util.Enumeration;
>>>>> import java.util.List;
>>>>> +import java.util.Locale;
>>>>> import java.util.TreeMap;
>>>>>
>>>>> import javax.servlet.ServletException;
>>>>> @@ -40,6 +41,7 @@ import static org.junit.Assert.assertNot
>>>>> import static org.junit.Assert.assertTrue;
>>>>> import static org.junit.Assert.fail;
>>>>>
>>>>> +import org.junit.Assert;
>>>>> import org.junit.Test;
>>>>>
>>>>> import org.apache.catalina.Context;
>>>>> @@ -660,7 +662,7 @@ public class TestRequest extends TomcatB
>>>>> writer.append("Content-Disposition: form-data;
>>>>> name=\"part\"\r\n");
>>>>> writer.append("Content-Type: text/plain; charset=UTF-8\r\n");
>>>>> writer.append("\r\n");
>>>>> - writer.append("äö").append("\r\n");
>>>>> + writer.append("��").append("\r\n");
>>>>>
>>>>
>>>> It looks like there is an encoding issue here ?!
>>>
>>> No. There is a known issue with the code that generates the commit mails
>>> and UTF-8.
>>
>> Saying that, that diff does look a little odd. The original looks more
>> reasonable but looking back at the history with viewvc shows the same
>> unprintable characters throughout which is odd.
>>
>> I wonder if there is a platform related thing going on here. The tests
>> pass - which is the main thing - but I'll do some more digging on this.
>
> Looks like the commit mailer issue is fixed (I haven't checked for a
> while).
I take that back. The mailer isn't fixed. viewvc is fine.
Mark
> viewvc also shows UTF-8 correctly as well.
>
> Moral of this thread. If we see something that looks like character
> corruption in commit logs or viewvc then now it probably is.
>
> Note that Windows uses cp1252 by default rather than UTF-8. I suspect
> that that is where the corruption sneaked in and I have changed the
> default for my Windows dev environment.
>
> Corruption fixed in trunk and 7.0.x.
>
> Mark
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
