2014-09-11 18:02 GMT+09:00 Mark Thomas <ma...@apache.org>: > On 11/09/2014 09:53, Keiichi Fujino wrote: > > 2014-09-11 17:37 GMT+09:00 Mark Thomas <ma...@apache.org>: > > > >> On 11/09/2014 09:34, kfuj...@apache.org wrote: > >>> Author: kfujino > >>> Date: Thu Sep 11 08:34:50 2014 > >>> New Revision: 1624222 > >>> > >>> URL: http://svn.apache.org/r1624222 > >>> Log: > >>> When deploying war, make sure that add dummy xml to the config base if > >> war does not have META-INF/context.xml or deployXML is false. > >> > >> Could you explain this please. > >> > >> > >> <dev-h...@tomcat.apache.org> > >> > > > > I think > > > > If war does not have META-INF/context.xm, dummy xml should add to config > > base. > > and > > If deployXML is false, dummy xml should add to config base. > > > > However in case copyThisXml is true, dummy xml never add to config base. > > It does not matter whether copyThisXml is true/false In this case. > > I don't think you mean add a dummy XML file to the config base. I think > you mean add an XML file in the config base to the redeploy resources so > if an XML file is created in the config base a redeploy will occur. > > The patch makes sense. The commit comment and the description in the > change log don't describe what the patch does. >
Thanks for comment and review. I will rewrite changelog entry. > > Mark > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > > -- > Keiichi.Fujino <dev-h...@tomcat.apache.org> >
