https://issues.apache.org/bugzilla/show_bug.cgi?id=56953
--- Comment #5 from Mark Thomas <ma...@apache.org> --- If you continue to ignore the comments you are given then this issue is going to get closed as WONTFIX. Your first patch was 86k and full of irrelevant changes. The second attempt is worse at 107k. Starting at the beginning of the patch: 1. The first chunk changes restores an svn keyword the Tomcat team previously removed. This change has nothing to do with this issue and should not be in this patch. 2. The second chunk reverts a fix to a constant name the Tomcat team previously fixed and removes some code necessary for Java 8 support. This change has nothing to do with this issue and should not be in this patch. Further this change breaks Java 8 support. 3. The third chunk makes further changes that have nothing to do with this issue and further breaks Java 8 support. And so on. I have no problem with reviewing a patch that completely replaces DataInputStream because of final methods. It is all the other irrelevant, breaking changes in the patch that are the problem. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
