https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
--- Comment #10 from Pierre Viret <pierre.vi...@gmail.com> ---
Thank you very much for your feedback.
1) About the circular dependency: the pattern for the tomcat-coyote component
selects the file "org/apache/tomcat/util/net/Constants.java".
This class is referenced by
"org.apache.tomcat.util.threads.TaskThreadFactory.java" which belongs to the
tomcat-util component. Actually only one constant field is used:
This field is defined like this in the Constants class:
public static final boolean IS_SECURITY_ENABLED =
(System.getSecurityManager() != null);
I think we can get rid of the circular dependency simply by modifying the
TaskThreadFactory class: replace the two lines which use the constant:
"if (Constants.IS_SECURITY_ENABLED) {"
With following: "if (System.getSecurityManager() != null) {"
and we should get the same result.
2) About the svn externals: this would be great! I don't know this feature so I
will study the svn documentation to understand how this would work. For
instance, is it possible to "reuse" the ant patterns defined in the build.xml
for selecting the right sources for each component?
3) I have started the implementation of a new maven project: apache-tomcat
which would create the distributions (as we can download them from
http://tomcat.apache.org/download-80.cgi). I will upload the new version of the
maven project files and the patch for the build.xml in this bug as soon as I
have a working base which would show how this can be implemented.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
