On 30/10/2014 08:48, Mark Thomas wrote: > On 30/10/2014 00:33, Konstantin Kolinko wrote: >> 2014-10-29 17:42 GMT+03:00 <ma...@apache.org>: >>> Author: markt >>> Date: Wed Oct 29 14:42:01 2014 >>> New Revision: 1635154 >>> >>> URL: http://svn.apache.org/r1635154 >>> Log: >>> URLs may be added directly to the web application's class path. ensure that >>> they are scanned if a StandardJarScanner is configured to scan the class >>> path. >>> >>> Added: >>> >>> tomcat/trunk/test/org/apache/tomcat/util/scan/TestStandardJarScanner.java >>> (with props) >>> Modified: >>> tomcat/trunk/java/org/apache/tomcat/util/scan/StandardJarScanner.java >>> tomcat/trunk/test/org/apache/catalina/filters/TesterServletContext.java >>> tomcat/trunk/webapps/docs/changelog.xml >>> >> >> (It was a fix for >> https://issues.apache.org/bugzilla/show_bug.cgi?id=57153 >> ) >> >> >> I suspect that this change is the trigger for breakage of >> org.apache.jasper.servlet.TestTldScanner test. > > I agree. I was looking at this last night and reached the same conclusion.
I've fixed the duplicate scanning of WEB-INF/lib/*.jar and WEB-INF/classes that uncovered this bug. <snip/> >> It may be that this bug did exist before, but that code path in >> StandardJarScanner just was not executed. > > That null doesn't look right. One of this morning's jobs is to look at that. Yep. It was a bug. Also fixed. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
