https://issues.apache.org/bugzilla/show_bug.cgi?id=57238

--- Comment #1 from Christopher Schultz <ch...@christopherschultz.net> ---
Thank you for your contribution!

A few comments on the patch:

0. "Author" tags have been discouraged, while the older contributors names have
been left in for ... nostalgia?

1. The level of detail you have added to security-howto.xml is probably not
necessary. The note about supporting OpenSSL-ciphers-style configuration should
be in the configuration section instead. I'm not sure it's appropriate to put
instructions for getting high scores on Qualys's SSL/TLS testing is
appropriate.

2. I wonder about the change in naming for the "SSL" sections to "SSL/TLS". I
think it's good, but might break URLs containing anchors in archives, other
sites, etc. The page will still exist of course, only the anchor will no longer
function. Perhaps you could add an explicit anchor alias using <a
name="Introduction to SSL"><!-- --></a><a name="Introduction_to_SSL"><!--
--></a> to be kind to the anchors.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to