On 07/02/2015 12:48, Mark Thomas wrote: > On 07/02/2015 11:06, Rémy Maucherat wrote: >> 2015-02-07 1:34 GMT+01:00 Konstantin Kolinko <knst.koli...@gmail.com>: >> >>> The new code does not reset lastValid and pos in case when pos == >>> lastValid and both are > 0. >>> >>> It shall be >>> >>> if (lastValid - pos > 0 && pos > 0) { >>> System.arraycopy(buf, pos, buf, 0, lastValid - pos); >>> } >>> lastValid = lastValid - pos; >>> pos = 0; >>> >> >> I agree it should be that, it looks less risky if the recycling does always >> reset a clean state. > > Agreed. I'll fix that over the weekend when I get 5 minutes in front of > the right machine (unless someone beats me to it).
Done. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org