Re: svn commit: r1658351 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/el/parser/ java/org/apache/jasper/compiler/ test/org/apache/el/ test/webapp-3.0/bug45nnn/ webapps/docs/

[Konstantin Kolinko]

2015-02-09 13:30 GMT+03:00  <ma...@apache.org>:
> Author: markt
> Date: Mon Feb  9 10:30:40 2015
> New Revision: 1658351
>
> URL: http://svn.apache.org/r1658351
> Log:
> Ensure only \${ and \#{ are treated as escapes for ${ and #{ rather than \$ 
> and \# being treated as escapes for $ and # when processing literal 
> expressions in expression language.
>
> Modified:
>     tomcat/tc7.0.x/trunk/   (props changed)
>     tomcat/tc7.0.x/trunk/java/org/apache/el/parser/AstLiteralExpression.java
>     tomcat/tc7.0.x/trunk/java/org/apache/jasper/compiler/ELParser.java
>     
> tomcat/tc7.0.x/trunk/java/org/apache/jasper/compiler/JspDocumentParser.java
>     tomcat/tc7.0.x/trunk/java/org/apache/jasper/compiler/Parser.java
>     tomcat/tc7.0.x/trunk/test/org/apache/el/TestELEvaluation.java
>     tomcat/tc7.0.x/trunk/test/org/apache/el/TestELInJsp.java
>     tomcat/tc7.0.x/trunk/test/webapp-3.0/bug45nnn/bug45451.jspf
>     tomcat/tc7.0.x/trunk/test/webapp-3.0/bug45nnn/bug45451d.jspx
>     tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
>


org.apache.jasper.compiler.TestELParser  test is failing on Tomcat 7.
It happens on Gump and I can reproduce it locally.
Two test cases out of 38 are failing.

Testsuite: org.apache.jasper.compiler.TestELParser
Tests run: 38, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0,42 sec

Testcase: testEscape04 took 0,006 sec
    FAILED
expected:<[]$> but was:<[\]$>
junit.framework.AssertionFailedError: expected:<[]$> but was:<[\]$>
    at 
org.apache.jasper.compiler.TestELParser.doTestParser(TestELParser.java:293)
    at 
org.apache.jasper.compiler.TestELParser.testEscape04(TestELParser.java:241)

Testcase: testEscape05 took 0 sec
    FAILED
expected:<[]#> but was:<[\]#>
junit.framework.AssertionFailedError: expected:<[]#> but was:<[\]#>
    at 
org.apache.jasper.compiler.TestELParser.doTestParser(TestELParser.java:293)
    at 
org.apache.jasper.compiler.TestELParser.testEscape05(TestELParser.java:247)



Also,
org.apache.jasper.compiler.TestParser FAILED

Testsuite: org.apache.jasper.compiler.TestParser
Tests run: 16, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 15.18 sec



Best regards,
Konstantin Kolinko

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org