https://issues.apache.org/bugzilla/show_bug.cgi?id=57540

--- Comment #8 from Christopher Schultz <ch...@christopherschultz.net> ---
(In reply to Ralf Hauser from comment #6)
> Created attachment 32437 [details]
> apache.tomcat.tls.protocol.57540.patch

Is IOException the most natural exception type for SSLSupport.getProtocol?
Under what circumstances do you expect an exception to be thrown (other than
APR, which will probably not throw an IOException when properly-implemented)?

If you aren't going to implement it yet for APR, you could throw
UnsupportedOperationException.... except that this code is called
unconditionally and without any try/catch in Http11Protocol, so the patch as it
stands will break requests coming from an APR connector. :(

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to