On 07/05/2015 14:14, Rémy Maucherat wrote: > 2015-05-07 15:09 GMT+02:00 Mark Thomas <ma...@apache.org>: > >> On 07/05/2015 13:47, Rémy Maucherat wrote: >>> 2015-05-07 13:24 GMT+02:00 <ma...@apache.org>: >>> >>>> Author: markt >>>> Date: Thu May 7 11:24:05 2015 >>>> New Revision: 1678169 >>>> >>>> URL: http://svn.apache.org/r1678169 >>>> Log: >>>> Retain the original configuration settings and use separate getters the >>>> absolute value for all file/path attributes >>>> >>> Usually duplicating config is not a good idea, right ? For example if >>> adjustRelativePath was static the calling code could use it dynamically >>> when needed. >> >> I was trying to avoid the callers having to worry about absolute vs. >> relative. If it wasn't for storeconfig (which will use the getters to >> save the config) I wouldn't have worried that the values changed between >> setters and getters. >> > > I wrote down I needed to add SSHostConfig support to storeconfig already, > although I'm waiting until it is stable. The extra fields can be ignored by > storeconfig, so it's not a real problem [it then needs to happen for JMX as > well], but in the end I don't think there's much difference between > getPathAbsolute and toAbsolute(getPath).
I think I am done with the config changes although I'd give it a while to see what bugs get reported. I need to add SSLHostConfig to JMX. That is next on my list. I'm wondering about a 9.0.0 M1 (milestone 1) release to give folks a chance to play with the SNI support. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
