Jean-Frederic,

On 6/15/15 7:27 AM, jean-frederic clere wrote:
> We have  empty stubs in tc-native when openssl isn't detected, are those
> still needed?
> 
> With NIO and NIO2 connectors we don't need native when we aren't using SSL.
> 
> Comments?

Having #ifdef'd some of those stubs myself, the idea was to make it so
you wouldn't crash the JVM if you called a native method from the Java
side of things. Those stubs are (obviously) no-ops but can protect the
user from bringing-down the server if they try to e.g. enable SSL with
OpenSSL was not built-in.

I would recommend leaving them in, though it might be cleaner to do it
in another way (I'm not sure how, though).

-chris

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to