Author: markt Date: Wed Jun 24 18:44:18 2015 New Revision: 1687340 URL: http://svn.apache.org/r1687340 Log: Fix FindBugs warning. Don't use != with Strings
Modified: tomcat/trunk/java/org/apache/catalina/filters/RemoteIpFilter.java Modified: tomcat/trunk/java/org/apache/catalina/filters/RemoteIpFilter.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/filters/RemoteIpFilter.java?rev=1687340&r1=1687339&r2=1687340&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/filters/RemoteIpFilter.java (original) +++ tomcat/trunk/java/org/apache/catalina/filters/RemoteIpFilter.java Wed Jun 24 18:44:18 2015 @@ -859,7 +859,7 @@ public class RemoteIpFilter implements F } HttpServletResponse xResponse; - if (xRequest.getScheme() != request.getScheme() || + if (!xRequest.getScheme().equals(request.getScheme()) || xRequest.getServerPort() != request.getServerPort()) { xResponse = new XForwardedResponse(response, xRequest.getScheme(), xRequest.getServerPort()); } else { --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org