Awesome. Let's backport that for safe measure. Thanks again for the ASM5 upgrade work. That's always so painful.
-- David Blevins http://twitter.com/dblevins http://www.tomitribe.com On Feb 1, 2015, at 2:57 AM, Romain Manni-Bucau <[email protected]> wrote: > no real reason - guess it was forgotten when supporting j8 cause it > was broken because of new asm api - reactivated on 2.x (only issue I > got was the new containerclassesfilter which is not in 1.7 so we > shouldnt have issues to backport it) > > > Romain Manni-Bucau > @rmannibucau > http://www.tomitribe.com > http://rmannibucau.wordpress.com > https://github.com/rmannibucau > > > 2015-02-01 6:11 GMT+01:00 David Blevins <[email protected]>: >> Seems the majority of checks were commented out in this commit: >> >> - >> https://github.com/apache/tomee/commit/6bbf5ce32d5a408bde13eefe393c6b1f3381a48d#diff-f6aa0817f9f5b87a8bae7a33578bc10f >> >> Any particular reason? >> >> The idea of those checks is to enforce constraints such as the singleton >> container should be independent and not have dependencies on the stateless >> container, etc. Making it possible for people to run server with just some >> containers (say singletons) and not others (MDBs or CMP for example) >> >> >> -David >>
