First of all a big thanks for the work Andy (know it hasnt been as easy as it can look from the list ;))!
I will vote --0 (actually a not blocking -1) cause it is a M1 and not a alpha/beta/final. Issues I see are: * asm clearly shouldnt be in the libs (cxf upgraded to the new asm and our exclusion was ignored - fixed on master since days * beans.xml is not handled if not in WEB-INF but WEB-INF/classes/META-INF (which breaks several apps) - idem * side note: we could have used OWB 1.6.1 as we did several time with parallel releases. This brings super impacting fixes so it would have worth it IMO but as said it is a M1 Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Tomitriber <http://www.tomitribe.com> 2015-06-18 0:35 GMT+02:00 Jean-Louis Monteiro <[email protected]>: > Adam, > > as you mentioned, OWB 1.6.1 hasn't been released so Andy could not embed > it. > It's a milestone so no issue so far in my opinion > > -- > Jean-Louis Monteiro > http://twitter.com/jlouismonteiro > http://www.tomitribe.com > > On Wed, Jun 17, 2015 at 7:20 PM, Adam Cornett <[email protected]> > wrote: > > > -1 without OWB 1.6.1 (vote pending, all +1s so far) > > > > On Wed, Jun 17, 2015 at 12:10 PM, Andy Gumbrecht < > [email protected] > > > > > wrote: > > > > > Hi everyone, > > > > > > This is the first milestone roll. Please take some time to review and > > > vote. We know it's not going to be perfect, so please only down-vote > > > critical issues. > > > > > > [generated email] > > > > > > Git: > > > https://git-wip-us.apache.org/repos/asf/tomee.git > > > tag: tomee-7.0.0-M1 > > > > > > Maven Repo: > > > > > > > https://repository.apache.org/content/repositories/orgapachetomee-1062 > > > > > > Binaries & Source: > > > > > > > > > https://dist.apache.org/repos/dist/dev/tomee/staging-1062/tomee-7.0.0-M1/ > > > > > > Legal: > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/tomee/staging-1062/legal/archives.html > > > > > > Vote will be open for 72 hours or as needed. > > > > > > -- > > > Andy Gumbrecht > > > https://twitter.com/AndyGeeDe > > > http://www.tomitribe.com > > > > > > > > > > > > -- > > Adam Cornett > > [email protected] > > (678) 296-1150 > > >
