Looks like we made as part of a routine Tomcat upgrade to change SystemInstance so that it modifies the System.getProperties
- commit: https://github.com/apache/tomee/commit/d9b5ea3f7218dc4bad1ebac7b8b674823fa3fa4c#diff-f51fa1817d7f3bd166acc0ea1b4f6b69 <https://github.com/apache/tomee/commit/d9b5ea3f7218dc4bad1ebac7b8b674823fa3fa4c#diff-f51fa1817d7f3bd166acc0ea1b4f6b69> - issue: https://issues.apache.org/jira/browse/TOMEE-740 <https://issues.apache.org/jira/browse/TOMEE-740> The goal for SystemInstance was specifically to remove dependency on System.getProperties so that embedded containers could be booted, used and discarded without polluting the System properties. This was all done as part of OpenEJB 1’s integration with Tomcat 4 (who feels old now?) which allowed you to have one embedded EJB container per webapp and also leveraged to allow cleaner Java SE integration so embedded EJB containers could be used and discarded with no scrubbing of the system properties. Saw some offline discussion saying “we need to clean up the system properties because the SystemInstance modifies them”, so thought it’s a good time to have a chat :) Any feedback on: - What motivated the change? - How do we rework that code? Ideally, we’d restore the ability to sequentially boot embedded containers, passing in properties and not have the actual properties used reflect some aggregate of all the containers that came before. -- David Blevins http://twitter.com/dblevins http://www.tomitribe.com
