Hi Ivan,
sorry, didn't see your mail and your PR, only the JIRA ticket (not yet sure
why but let's blame the human between the computer and keyboard until we
identify something else)
The PR looks good with few notes:
- int -> integer: not needed
- count() doesn't need to return Response but can still return int (you
already fixed the text_plain issue)
- why adding eclipselink metadata since we run with openjpa?
- you mention jackson but we use johnzon ("typo" i guess)
Looks a lot but that's globally details, the only part you missed was the
string->int conversion (my impl is not the sexiest in term of js but does
the job).
Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> | Blog
<https://blog-rmannibucau.rhcloud.com> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | JavaEE Factory
<https://javaeefactory-rmannibucau.rhcloud.com>
2017-01-16 23:25 GMT+01:00 Ivan Junckes Filho <ivanjunc...@gmail.com>:
> Hey guys, I didn't receive any feedback on the request. As I said I am very
> interested in contribute more to tomee, but not having a proper feedback is
> a bit discouraging.
>
> I spent a few hours with that PR so I would appreciate a lot if you guys
> could merge it.
>
> Thank you.
>
> On Wed, Jan 11, 2017 at 9:31 AM, Ivan Junckes Filho <ivanjunc...@gmail.com
> >
> wrote:
>
> > Hi guys,
> >
> > I created a PR https://github.com/apache/tomee/pull/56, for an issue
> > with moviefun-rest example. The app was not working with tomee 7 and I
> was
> > able to fix it. Also created a ticket TOME-1998 to that PR.
> >
> > This morning I looked and saw there was a change to fix TOMEE-1998 and my
> > PR was not taken care of.
> > https://github.com/apache/tomee/commit/cd1e39e721db73269ab18b540fbe1d
> > f110e5cc0a
> >
> > This change broke my PR and it is not enough to solve all issues with
> > Tomee 7. I am trying to get engaged and collaborate more so would be nice
> > if my PR is considered for this task.
> >
> > Thank you.
> >
>
