Hello,

In *one* of the configuration factory constructors a system property is set:

public ConfigurationFactory() {
    this(!shouldAutoDeploy());
    System.setProperty("bval.in-container", "true");
}

What do you think about moving this to system.properties ? The reason is
that:
* it's really hidden and not obvious why it's there
* it's being set every time in case of vanilla tomee
* it's not set when using custom configuration factory when you use one of
the other constructors (and this breaks CDI)
* IMO it's a good idea to have all global properties at one place, instead
of being scattered in the source

Kind regards,
Svetlin

Reply via email to