Hi Mark, think we already discuss it somewhere else but wrote again the points inline if it has been missed
Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book <https://www.packtpub.com/application-development/java-ee-8-high-performance> Le mer. 27 juin 2018 à 10:48, Mark Struberg <strub...@yahoo.de.invalid> a écrit : > Hi folks! > > While trying to release TomEE-7.0.5 I figured that the Examples as part of > the TomEE core project are really counter productive. > > * they break the maven-release-plugin, because they don't use the same > version > Moving it to another repo will not solve it since they must be independent and not have a common parent to be copiable and runnable without dependencies. They should also depend on current tomee snapshot and be aligned on tomee lifecycle for that reason(cause they can show feature we just added on master). Not sure how you plan to solve it in another repo but doable. Also I'm not sure we'll use the plugin anyway since it doesn't fit much big projects and with git it is useless to go through the full lifecycle (you use local branches/tags you push later so no potential conflicts like you can have with svn). You can save half of the release time not using it ;). > * They pollute the build (samples alone take 15 minutes of our build), > which might lower contributions > See it the other way around. It is part of the build cause mainly used as integration tests for a big part of them so if you drop them you must move all the tests to the main build before doing it which will lead to just save ~5mn on 3h of build (CI). > * They are bound to a specific tomee version, so they cannot easily be > tested against another version > Each release manager should ensure it is bumped to next master version, we can have missed it a bit but this is a bug we should fix. > * We have many people who want to probably add samples without wanting to > go through all the hassle to build full tomee > This is the case by design since they are independent. > > Of course there are also downsides, mainly: > * by having the samples as part of our build we also have improved test > coverage. > > Well, since right now almost nobody runs the tests when building TomEE > (but instead rely on our CI, because it takes so long) it makes no > difference anyway. I'd rather have a core project with decently good test > coverage - and people also run it - than having a bit better coverage > which nobody runs. > I don't get what it changes here since if you drop 15mn you still have something like 3h to run. > > So I propose to move the Examples to a separate repo and add a separate CI > for it. > Anyaway if we go that path we can just contribute most of them back to javaee_samples and only keep our specific ones. > Of course we should look at how to set it up so we can have samples for > multiple EE versions. > Our site is not versionned (think we said it was too costly to maintain to do it earlier, not sure we still stand on that point) so not sure it is important. However we must still generate the example pages etc in our site generation so if they move we should ensure it is not broken. > > wdyt? > To summarize it to make it very clear I'm +-0 (as really neutral since it doesn't change anything at the end IMHO) to drop them IF (and only if) the coverage is contributed back to the main project. > > LieGrue, > strub > >
