Hey Roberto, Thanks for the PR. I have reviewed it and it looks good. So I'll proceed and merge. I'll see if I can throw a vote out for the 7.1.x
+1 to switch master to 8.x as discussed. For TomEE 8.x we can try adding all the other microprofile implementations available at apache. Jean-Louis -- Jean-Louis Monteiro http://twitter.com/jlouismonteiro http://www.tomitribe.com On Thu, Jul 26, 2018 at 11:04 AM, Jonathan Gallimore < [email protected]> wrote: > On Thu, Jul 26, 2018 at 5:57 AM, Romain Manni-Bucau <[email protected] > > > wrote: > > > Hi guys > > > > Didnt we plan to switch master to tomee 8 after the 7.0.5? > > > We did agree that, and I'm happy to do that provided we can keep a branch > for 7.0.x to maintain it. Unless anyone throws an objection on that in the > next couple of hours, I'll switch that over today. I think it has been > discussed plenty. > > > > Also not sure we > > want the 7.1 (we didnt finish the discussion IIRC). > > > > I'm sure we want the MP stuff in TomEE 8 as well, but I'd be in favour of a > TomEE 7.1 also. > > > > > > As a side note: geronimo is MP complete (yes I didnt resist to the joke) > so > > maybe time to just import it all? > > > > I'd certainly be happy to give that a go. > > Jon > > > > > > Romain > > > > > > Le jeu. 26 juil. 2018 01:26, Jonathan Gallimore < > > [email protected]> a écrit : > > > > > Awesome, thanks Roberto! > > > > > > On Wed, Jul 25, 2018 at 7:16 PM, Roberto Cortez > > > <[email protected] > > > > wrote: > > > > > > > Hi everyone, > > > > I've picked up some of the work started by JL on the tomee-7.1.x > branch > > > to > > > > have a release with some MP support. > > > > I've updated the branch with the latest 7.0.5 code, plus, fixed some > > > > issues with the MP Configuration and MP JWT integration. > > > > I've opened the following PR:https://github.com/apache/ > tomee/pull/138 > > > > > > > > Hope it is ok. > > > > Cheers,Roberto > > > > > >
