Ok! Thanks!

> On 12 Oct 2018, at 17:23, Thomas Andraschko <[email protected]> 
> wrote:
> 
> *start any app with the maven embedded plugin
> 
> Roberto Cortez <[email protected]> schrieb am Fr., 12. Okt. 2018,
> 17:21:
> 
>> Hi Thomas,
>> 
>> If you already have an app that you can share with me that reproduces the
>> issue it would be great. If not I’ll do one here.
>> 
>> Cheers,
>> Roberto
>> 
>>> On 12 Oct 2018, at 15:37, Thomas Andraschko <[email protected]>
>> wrote:
>>> 
>>> Yep, it doesn't work there either.
>>> BVal 1.x doesn't require so much metadata-lookup as 2.x, so therefore the
>>> overhead is now much bigger in TomEE8.x now
>>> 
>>> 
>>> 
>>> 
>>> Am Fr., 12. Okt. 2018 um 16:32 Uhr schrieb Roberto Cortez
>>> <[email protected]>:
>>> 
>>>> Did you check if this also happens in TomEE 7.x?
>>>> 
>>>>> On 12 Oct 2018, at 15:29, Thomas Andraschko <
>> [email protected]>
>>>> wrote:
>>>>> 
>>>>> Yep
>>>>> 1 min ago i just verified that it only occurs on embedded-maven-plugin
>>>>> 
>>>>> maybe you have a good idea to fix it
>>>>> 
>>>>> in meantime i will check if we should enhance the BValCdiFilter.
>>>>> 
>>>>> Am Fr., 12. Okt. 2018 um 16:25 Uhr schrieb Roberto Cortez
>>>>> <[email protected]>:
>>>>> 
>>>>>> Thomas, you mean that in the same context and execution if you try
>>>>>> loadClass you get the ClassNotFound but the Class.forName is able to
>>>> load
>>>>>> the class?
>>>>>> 
>>>>>> Cheers,
>>>>>> Roberto
>>>>>> 
>>>>>>> On 12 Oct 2018, at 13:44, Romain Manni-Bucau <[email protected]>
>>>>>> wrote:
>>>>>>> 
>>>>>>> ok, means the TCCL can have changed and be wrong here due to a change
>>>> in
>>>>>>> the eager boot code which can capture apploader or maven classloader
>>>>>>> instead of the mojo classloader.
>>>>>>> 
>>>>>>> Romain Manni-Bucau
>>>>>>> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
>>>>>>> <https://rmannibucau.metawerx.net/> | Old Blog
>>>>>>> <http://rmannibucau.wordpress.com> | Github <
>>>>>> https://github.com/rmannibucau> |
>>>>>>> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
>>>>>>> <
>>>>>> 
>>>> 
>> https://www.packtpub.com/application-development/java-ee-8-high-performance
>>>>>>> 
>>>>>>> 
>>>>>>> 
>>>>>>> Le ven. 12 oct. 2018 à 14:31, Thomas Andraschko <
>>>>>> [email protected]>
>>>>>>> a écrit :
>>>>>>> 
>>>>>>>> i'm on tomee-embedded-maven-plugin
>>>>>>>> 
>>>>>>>> Am Fr., 12. Okt. 2018 um 14:09 Uhr schrieb Romain Manni-Bucau <
>>>>>>>> [email protected]>:
>>>>>>>> 
>>>>>>>>> hmm the loader is the parent loader (container one) and it must
>> work,
>>>>>> are
>>>>>>>>> you in a plain tomee or another flavor like tomee-embedded or
>> other?
>>>>>>>>> Class.forName uses the caller classloader which should be the same
>>>> here
>>>>>>>> in
>>>>>>>>> the best case
>>>>>>>>> 
>>>>>>>>> Romain Manni-Bucau
>>>>>>>>> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
>>>>>>>>> <https://rmannibucau.metawerx.net/> | Old Blog
>>>>>>>>> <http://rmannibucau.wordpress.com> | Github <
>>>>>>>>> https://github.com/rmannibucau> |
>>>>>>>>> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
>>>>>>>>> <
>>>>>>>>> 
>>>>>>>> 
>>>>>> 
>>>> 
>> https://www.packtpub.com/application-development/java-ee-8-high-performance
>>>>>>>>>> 
>>>>>>>>> 
>>>>>>>>> 
>>>>>>>>> Le ven. 12 oct. 2018 à 12:38, Thomas Andraschko <
>>>>>>>>> [email protected]>
>>>>>>>>> a écrit :
>>>>>>>>> 
>>>>>>>>>> I dont think thats related to bval, class.forName works fine
>>>>>>>>>> 
>>>>>>>>>> Romain Manni-Bucau <[email protected]> schrieb am Fr., 12.
>> Okt.
>>>>>>>>> 2018,
>>>>>>>>>> 12:20:
>>>>>>>>>> 
>>>>>>>>>>> Le ven. 12 oct. 2018 11:10, Thomas Andraschko <
>>>>>>>>>> [email protected]
>>>>>>>>>>>> 
>>>>>>>>>>> a écrit :
>>>>>>>>>>> 
>>>>>>>>>>>> Hi,
>>>>>>>>>>>> 
>>>>>>>>>>>> found a bug, which is related to a slow startup as discussed in
>>>> the
>>>>>>>>>> other
>>>>>>>>>>>> thread.
>>>>>>>>>>>> 
>>>>>>>>>>>> See: https://issues.apache.org/jira/browse/TOMEE-2258
>>>>>>>>>>>> the lookup:
>>>>>>>> loader.loadClass("org.apache.openejb.bval.BValCdiFilter")
>>>>>>>>>>>> fails with a ClassNotFound
>>>>>>>>>>>> 
>>>>>>>>>>>> could someone check this?
>>>>>>>>>>>> We could easily change it to Class.forName - but not sure what
>> is
>>>>>>>> the
>>>>>>>>>>>> correct classloader.
>>>>>>>>>>>> 
>>>>>>>>>>> 
>>>>>>>>>>> Openejb core one so should be good. I guess it is a transitive
>>>> issue
>>>>>>>>> or a
>>>>>>>>>>> breaking change in bval we can fix
>>>>>>>>>>> 
>>>>>>>>>>> 
>>>>>>>>>>> 
>>>>>>>>>>>> We should definitily fix such bugs as the startup with TomEE8,
>>>>>>>>> compared
>>>>>>>>>>> to
>>>>>>>>>>>> TomEE7, is double as slow.
>>>>>>>>>>>> 
>>>>>>>>>>>> Best regards,
>>>>>>>>>>>> Thomas
>>>>>>>>>>>> 
>>>>>>>>>>> 
>>>>>>>>>> 
>>>>>>>>> 
>>>>>>>> 
>>>>>> 
>>>>>> 
>>>> 
>>>> 
>> 
>> 

Reply via email to