without is what we do @geronimo and what makes sense at MP IMHO since otherwise you just start breaking the consistency of the stack in terms of exposed API (@spec level, not tomee one) and dependencies (tomee level)
I know currently the governance in MP is quite bad since each spec lead tries to - does - enforce its job/$$ choices into the spec and forget about the overall platform consistency but IMHO TomEE must stay as clean as possible to not just provide an unusable and misleading distribution to end users. At least that's how we built it @geronimo. Romain Manni-Bucau @rmannibucau <https://twitter.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book <https://www.packtpub.com/application-development/java-ee-8-high-performance> Le sam. 13 oct. 2018 à 23:48, Roberto Cortez <[email protected]> a écrit : > We do need it to pass the TCK. So what would you recommend? Should we ship > without it? Or we can just ship it with the MP flavour. > > > On 13 Oct 2018, at 22:38, Romain Manni-Bucau <[email protected]> > wrote: > > > > It is really optional functionally and throught as such. > > It is used to support yaml only - and undertested to be honest - so > > normally not used at all in MP apps which are about JSON first (core) and > > json is there OOTB. > > > > Romain Manni-Bucau > > @rmannibucau <https://twitter.com/rmannibucau> | Blog > > <https://rmannibucau.metawerx.net/> | Old Blog > > <http://rmannibucau.wordpress.com> | Github < > https://github.com/rmannibucau> | > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book > > < > https://www.packtpub.com/application-development/java-ee-8-high-performance > > > > > > > > Le sam. 13 oct. 2018 à 23:29, Roberto Cortez <[email protected] > > > > a écrit : > > > >> You have an optional dependency to jackson from geronimo open-api. > >> > >>> On 13 Oct 2018, at 22:18, Romain Manni-Bucau <[email protected]> > >> wrote: > >>> > >>> wdym? > >>> > >>> Romain Manni-Bucau > >>> @rmannibucau <https://twitter.com/rmannibucau> | Blog > >>> <https://rmannibucau.metawerx.net/> | Old Blog > >>> <http://rmannibucau.wordpress.com> | Github < > >> https://github.com/rmannibucau> | > >>> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book > >>> < > >> > https://www.packtpub.com/application-development/java-ee-8-high-performance > >>> > >>> > >>> > >>> Le sam. 13 oct. 2018 à 23:14, Roberto Cortez > <[email protected] > >>> > >>> a écrit : > >>> > >>>> By the way, and what about openapi? > >>>> > >>>>> On 13 Oct 2018, at 22:12, Roberto Cortez <[email protected] > > > >>>> wrote: > >>>>> > >>>>> Very well. I’ll try to exclude it. > >>>>> > >>>>>> On 13 Oct 2018, at 21:48, Romain Manni-Bucau <[email protected] > > > >>>> wrote: > >>>>>> > >>>>>> PS: this code didn't change since 2 years so we can likely exclude > it. > >>>> Also > >>>>>> opened https://github.com/apache/activemq/pull/308 but not sure it > >>>> will be > >>>>>> that welcomed in current way. > >>>>>> > >>>>>> Romain Manni-Bucau > >>>>>> @rmannibucau <https://twitter.com/rmannibucau> | Blog > >>>>>> <https://rmannibucau.metawerx.net/> | Old Blog > >>>>>> <http://rmannibucau.wordpress.com> | Github < > >>>> https://github.com/rmannibucau> | > >>>>>> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book > >>>>>> < > >>>> > >> > https://www.packtpub.com/application-development/java-ee-8-high-performance > >>>>> > >>>>>> > >>>>>> > >>>>>> Le sam. 13 oct. 2018 à 08:24, Romain Manni-Bucau < > >> [email protected]> > >>>> a > >>>>>> écrit : > >>>>>> > >>>>>>> this is an optional part so we can workaround it and we should open > >> an > >>>>>>> issue to ask AMQ to use jsonb. They are preparing a release these > >> days > >>>> so > >>>>>>> hopefully it can make it. > >>>>>>> > >>>>>>> Romain Manni-Bucau > >>>>>>> @rmannibucau <https://twitter.com/rmannibucau> | Blog > >>>>>>> <https://rmannibucau.metawerx.net/> | Old Blog > >>>>>>> <http://rmannibucau.wordpress.com> | Github > >>>>>>> <https://github.com/rmannibucau> | LinkedIn > >>>>>>> <https://www.linkedin.com/in/rmannibucau> | Book > >>>>>>> < > >>>> > >> > https://www.packtpub.com/application-development/java-ee-8-high-performance > >>>>> > >>>>>>> > >>>>>>> > >>>>>>> Le sam. 13 oct. 2018 à 01:24, Roberto Cortez > >>>> <[email protected]> > >>>>>>> a écrit : > >>>>>>> > >>>>>>>> Hi Romain, > >>>>>>>> > >>>>>>>> Jackson is now included by activemq-broker 5.15. It is using their > >> API > >>>>>>>> directly. I’m not sure if we can remove it. > >>>>>>>> > >>>>>>>> Here: > >>>>>>>> > >>>>>>>> > >>>> > >> > https://github.com/apache/activemq/blob/e8ba0b0119df071e809861b4e4a4632d089a5055/activemq-broker/src/main/java/org/apache/activemq/broker/jmx/DestinationsViewFilter.java#L99 > >>>>>>>> < > >>>>>>>> > >>>> > >> > https://github.com/apache/activemq/blob/e8ba0b0119df071e809861b4e4a4632d089a5055/activemq-broker/src/main/java/org/apache/activemq/broker/jmx/DestinationsViewFilter.java#L99 > >>>>>>>>> > >>>>>>>> > >>>>>>>> > >>>> > >> > https://github.com/apache/activemq/blob/d54d046b8a8f2e9e5c0a28e1f8c7634b3c8b18e4/activemq-broker/src/main/java/org/apache/activemq/broker/jmx/BrokerView.java#L288-L300 > >>>>>>>> < > >>>>>>>> > >>>> > >> > https://github.com/apache/activemq/blob/d54d046b8a8f2e9e5c0a28e1f8c7634b3c8b18e4/activemq-broker/src/main/java/org/apache/activemq/broker/jmx/BrokerView.java#L288-L300 > >>>>>>>>> > >>>>>>>> > >>>>>>>> From this issue: https://issues.apache.org/jira/browse/AMQ-6435 < > >>>>>>>> https://issues.apache.org/jira/browse/AMQ-6435> > >>>>>>>> > >>>>>>>> Do you see an alternative? > >>>>>>>> > >>>>>>>> Cheers, > >>>>>>>> Roberto > >>>>>>>> > >>>>>>>>> On 12 Oct 2018, at 22:53, Romain Manni-Bucau < > >> [email protected]> > >>>>>>>> wrote: > >>>>>>>>> > >>>>>>>>> Hello Roberto > >>>>>>>>> > >>>>>>>>> Any reason to not exclude it as usual? > >>>>>>>>> > >>>>>>>>> ---------- Forwarded message --------- > >>>>>>>>> From: <[email protected]> > >>>>>>>>> Date: ven. 12 oct. 2018 23:36 > >>>>>>>>> Subject: [2/5] tomee git commit: Added Jackson notice to plus and > >>>> plume. > >>>>>>>>> To: <[email protected]> > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> Added Jackson notice to plus and plume. > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> Project: http://git-wip-us.apache.org/repos/asf/tomee/repo > >>>>>>>>> Commit: > >> http://git-wip-us.apache.org/repos/asf/tomee/commit/0c2772e3 > >>>>>>>>> Tree: http://git-wip-us.apache.org/repos/asf/tomee/tree/0c2772e3 > >>>>>>>>> Diff: http://git-wip-us.apache.org/repos/asf/tomee/diff/0c2772e3 > >>>>>>>>> > >>>>>>>>> Branch: refs/heads/master > >>>>>>>>> Commit: 0c2772e36e8617b7eee9509e3bf16e6908cca557 > >>>>>>>>> Parents: e14ae95 > >>>>>>>>> Author: Roberto Cortez <[email protected]> > >>>>>>>>> Authored: Fri Oct 12 13:07:06 2018 +0100 > >>>>>>>>> Committer: Roberto Cortez <[email protected]> > >>>>>>>>> Committed: Fri Oct 12 13:17:51 2018 +0100 > >>>>>>>>> > >>>>>>>>> > >>>> ---------------------------------------------------------------------- > >>>>>>>>> tomee/apache-tomee/src/main/resources/META-INF/plume/NOTICE | 9 > >>>>>>>> ++++++++- > >>>>>>>>> tomee/apache-tomee/src/main/resources/META-INF/plus/NOTICE | 9 > >>>>>>>> ++++++++- > >>>>>>>>> tomee/tomee-plume-webapp/src/main/resources/META-INF/NOTICE | 9 > >>>>>>>> ++++++++- > >>>>>>>>> tomee/tomee-plus-webapp/src/main/resources/META-INF/NOTICE | 9 > >>>>>>>> ++++++++- > >>>>>>>>> 4 files changed, 32 insertions(+), 4 deletions(-) > >>>>>>>>> > >>>> ---------------------------------------------------------------------- > >>>>>>>>> > >>>>>>>>> > >>>>>>>>> > >>>>>>>> > >>>> > >> > http://git-wip-us.apache.org/repos/asf/tomee/blob/0c2772e3/tomee/apache-tomee/src/main/resources/META-INF/plume/NOTICE > >>>>>>>>> > >>>> ---------------------------------------------------------------------- > >>>>>>>>> diff --git > >>>> a/tomee/apache-tomee/src/main/resources/META-INF/plume/NOTICE > >>>>>>>>> b/tomee/apache-tomee/src/main/resources/META-INF/plume/NOTICE > >>>>>>>>> index a3c5862..be9aca1 100644 > >>>>>>>>> --- a/tomee/apache-tomee/src/main/resources/META-INF/plume/NOTICE > >>>>>>>>> +++ b/tomee/apache-tomee/src/main/resources/META-INF/plume/NOTICE > >>>>>>>>> @@ -167,4 +167,11 @@ Joda.org (http://www.joda.org/). > >>>>>>>>> > >>>>>>>> > >>>> > >> > ========================================================================= > >>>>>>>>> This product includes software developed and copyrighted by the > The > >>>>>>>> OWASP > >>>>>>>>> Foundation (https://www.owasp.org) > >>>>>>>>> > >>>>>>>> > >>>> > >> > -========================================================================= > >>>>>>>>> \ No newline at end of file > >>>>>>>>> > >>>>>>>> > >>>> > >> > +========================================================================= > >>>>>>>>> +Jackson JSON processor > >>>>>>>>> +Jackson is a high-performance, Free/Open Source JSON processing > >>>>>>>> library. > >>>>>>>>> +It was originally written by Tatu Saloranta ( > >> [email protected] > >>>> ), > >>>>>>>> and > >>>>>>>>> has > >>>>>>>>> +been in development since 2007. > >>>>>>>>> +It is currently developed by a community of developers, as well > as > >>>>>>>>> supported > >>>>>>>>> +commercially by FasterXML.com. > >>>>>>>>> > >>>>>>>> > >>>> > >> > +========================================================================= > >>>>>>>>> > >>>>>>>>> > >>>>>>>> > >>>> > >> > http://git-wip-us.apache.org/repos/asf/tomee/blob/0c2772e3/tomee/apache-tomee/src/main/resources/META-INF/plus/NOTICE > >>>>>>>>> > >>>> ---------------------------------------------------------------------- > >>>>>>>>> diff --git > >>>> a/tomee/apache-tomee/src/main/resources/META-INF/plus/NOTICE > >>>>>>>>> b/tomee/apache-tomee/src/main/resources/META-INF/plus/NOTICE > >>>>>>>>> index ba6bde2..a2da07e 100644 > >>>>>>>>> --- a/tomee/apache-tomee/src/main/resources/META-INF/plus/NOTICE > >>>>>>>>> +++ b/tomee/apache-tomee/src/main/resources/META-INF/plus/NOTICE > >>>>>>>>> @@ -160,4 +160,11 @@ Joda.org (http://www.joda.org/). > >>>>>>>>> > >>>>>>>> > >>>> > >> > ========================================================================= > >>>>>>>>> This product includes software developed and copyrighted by the > The > >>>>>>>> OWASP > >>>>>>>>> Foundation (https://www.owasp.org) > >>>>>>>>> > >>>>>>>> > >>>> > >> > -========================================================================= > >>>>>>>>> \ No newline at end of file > >>>>>>>>> > >>>>>>>> > >>>> > >> > +========================================================================= > >>>>>>>>> +Jackson JSON processor > >>>>>>>>> +Jackson is a high-performance, Free/Open Source JSON processing > >>>>>>>> library. > >>>>>>>>> +It was originally written by Tatu Saloranta ( > >> [email protected] > >>>> ), > >>>>>>>> and > >>>>>>>>> has > >>>>>>>>> +been in development since 2007. > >>>>>>>>> +It is currently developed by a community of developers, as well > as > >>>>>>>>> supported > >>>>>>>>> +commercially by FasterXML.com. > >>>>>>>>> > >>>>>>>> > >>>> > >> > +========================================================================= > >>>>>>>>> > >>>>>>>>> > >>>>>>>> > >>>> > >> > http://git-wip-us.apache.org/repos/asf/tomee/blob/0c2772e3/tomee/tomee-plume-webapp/src/main/resources/META-INF/NOTICE > >>>>>>>>> > >>>> ---------------------------------------------------------------------- > >>>>>>>>> diff --git > >>>> a/tomee/tomee-plume-webapp/src/main/resources/META-INF/NOTICE > >>>>>>>>> b/tomee/tomee-plume-webapp/src/main/resources/META-INF/NOTICE > >>>>>>>>> index 4d74e4a..e641f49 100644 > >>>>>>>>> --- a/tomee/tomee-plume-webapp/src/main/resources/META-INF/NOTICE > >>>>>>>>> +++ b/tomee/tomee-plume-webapp/src/main/resources/META-INF/NOTICE > >>>>>>>>> @@ -121,4 +121,11 @@ Joda.org (http://www.joda.org/). > >>>>>>>>> > >>>>>>>> > >>>> > >> > ========================================================================= > >>>>>>>>> This product includes software developed and copyrighted by the > The > >>>>>>>> OWASP > >>>>>>>>> Foundation (https://www.owasp.org) > >>>>>>>>> > >>>>>>>> > >>>> > >> > -========================================================================= > >>>>>>>>> \ No newline at end of file > >>>>>>>>> > >>>>>>>> > >>>> > >> > +========================================================================= > >>>>>>>>> +Jackson JSON processor > >>>>>>>>> +Jackson is a high-performance, Free/Open Source JSON processing > >>>>>>>> library. > >>>>>>>>> +It was originally written by Tatu Saloranta ( > >> [email protected] > >>>> ), > >>>>>>>> and > >>>>>>>>> has > >>>>>>>>> +been in development since 2007. > >>>>>>>>> +It is currently developed by a community of developers, as well > as > >>>>>>>>> supported > >>>>>>>>> +commercially by FasterXML.com. > >>>>>>>>> > >>>>>>>> > >>>> > >> > +========================================================================= > >>>>>>>>> > >>>>>>>>> > >>>>>>>> > >>>> > >> > http://git-wip-us.apache.org/repos/asf/tomee/blob/0c2772e3/tomee/tomee-plus-webapp/src/main/resources/META-INF/NOTICE > >>>>>>>>> > >>>> ---------------------------------------------------------------------- > >>>>>>>>> diff --git > >>>> a/tomee/tomee-plus-webapp/src/main/resources/META-INF/NOTICE > >>>>>>>>> b/tomee/tomee-plus-webapp/src/main/resources/META-INF/NOTICE > >>>>>>>>> index 1b5bf26..a294662 100644 > >>>>>>>>> --- a/tomee/tomee-plus-webapp/src/main/resources/META-INF/NOTICE > >>>>>>>>> +++ b/tomee/tomee-plus-webapp/src/main/resources/META-INF/NOTICE > >>>>>>>>> @@ -114,4 +114,11 @@ Joda.org (http://www.joda.org/). > >>>>>>>>> > >>>>>>>> > >>>> > >> > ========================================================================= > >>>>>>>>> This product includes software developed and copyrighted by the > The > >>>>>>>> OWASP > >>>>>>>>> Foundation (https://www.owasp.org) > >>>>>>>>> > >>>>>>>> > >>>> > >> > -========================================================================= > >>>>>>>>> \ No newline at end of file > >>>>>>>>> > >>>>>>>> > >>>> > >> > +========================================================================= > >>>>>>>>> +Jackson JSON processor > >>>>>>>>> +Jackson is a high-performance, Free/Open Source JSON processing > >>>>>>>> library. > >>>>>>>>> +It was originally written by Tatu Saloranta ( > >> [email protected] > >>>> ), > >>>>>>>> and > >>>>>>>>> has > >>>>>>>>> +been in development since 2007. > >>>>>>>>> +It is currently developed by a community of developers, as well > as > >>>>>>>>> supported > >>>>>>>>> +commercially by FasterXML.com. > >>>>>>>>> > >>>>>>>> > >>>> > >> > +========================================================================= > >>>>>>>> > >>>>>>>> > >>>>> > >>>> > >>>> > >> > >> > >
