Hi, I updated the PR with tests!
Em seg, 29 de out de 2018 às 08:27, Jonathan Gallimore < jonathan.gallim...@gmail.com> escreveu: > I saw your note on the PR regarding Romain's feedback. > > For visibility here, Romain is querying whether this patch will cause an > issue with folks calling the CLI with a custom classpath using `java -cp > ...` under Java 8. I'd suggest we add a test for it, which looks to be what > Daniel is doing. > > Thanks guys. > > Jon > > On Thu, Oct 25, 2018 at 12:35 PM Daniel Cunha <daniels...@apache.org> > wrote: > > > Hi Folks, > > > > I sent a PR on TomEE to fix the TOMEE-2253. I got a lot of feedback from > > Romain (thank you Romain for all comments and help) > > > > I believe which we are in good shape to merge. > > The changes cover from Java 8 till Java 11 which not provide any impact > for > > TomEE or application deployed on it. > > > > Please, look at the PR and let me know what you think. > > > > PR: https://github.com/apache/tomee/pull/176 > > > > -- > > Daniel "soro" Cunha > > https://twitter.com/dvlc_ > > > -- Daniel "soro" Cunha https://twitter.com/dvlc_
